fix: deactivate all disciplines when entering/exiting the Spire
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s

- Add deactivateAll() action to discipline-slice.ts
- Call deactivateAll() in createEnterSpireMode() (combat-descent-actions.ts)
- Add spireMode guard in gameStore.ts tick() to skip discipline processTick
- Call deactivateAll() in exitSpireMode() (combatStore.ts) as safety measure
- Extract buildConversionParams to utils/conversion-params.ts to keep gameStore.ts under 400 lines
- Add regression tests (5 tests, all 1136 passing)

Fixes #347
This commit is contained in:
2026-06-10 11:41:25 +02:00
parent 076282caf3
commit 48eee17d43
10 changed files with 295 additions and 30 deletions
+4 -3
View File
@@ -1,9 +1,10 @@
# Circular Dependencies
Generated: 2026-06-10T08:50:57.213Z
Found: 2 circular chain(s) — these MUST be fixed before modifying involved files.
Generated: 2026-06-10T09:19:26.381Z
Found: 3 circular chain(s) — these MUST be fixed before modifying involved files.
1. 1) stores/golem-combat-actions.ts > stores/golem-combat-helpers.ts
2. 2) stores/combatStore.ts > stores/combat-descent-actions.ts > stores/attunementStore.ts
2. 2) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts
3. 3) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts > stores/non-combat-room-actions.ts
## How to fix
1. Identify which import in the chain can be extracted to a shared types/utils file.
+2 -1
View File
@@ -1,6 +1,6 @@
{
"_meta": {
"generated": "2026-06-10T08:50:54.740Z",
"generated": "2026-06-10T09:19:24.358Z",
"description": "Import dependency graph for src/lib/game. Keys are files, values are arrays of files they import.",
"usage": "To find what a file affects, search for its path in the VALUES. To find what a file depends on, look at its KEY entry."
},
@@ -529,6 +529,7 @@
"effects/discipline-effects.ts",
"effects/special-effects.ts",
"effects/upgrade-effects.ts",
"stores/attunementStore.ts",
"stores/combatStore.ts",
"stores/gameStore.ts",
"stores/manaStore.ts",
+2
View File
@@ -213,6 +213,7 @@ Mana-Loop/
│ │ │ │ ├── cross-module-prestige-discipline.test.ts
│ │ │ │ ├── curse-amplification.test.ts
│ │ │ │ ├── design-validation-perk-gating.test.ts
│ │ │ │ ├── discipline-deactivate-on-spire-entry.test.ts
│ │ │ │ ├── discipline-math.test.ts
│ │ │ │ ├── discipline-prerequisites.test.ts
│ │ │ │ ├── discipline-reactivate-bug.test.ts
@@ -410,6 +411,7 @@ Mana-Loop/
│ │ │ ├── utils/
│ │ │ │ ├── activity-log.ts
│ │ │ │ ├── combat-utils.ts
│ │ │ │ ├── conversion-params.ts
│ │ │ │ ├── conversion-rates.ts
│ │ │ │ ├── discipline-math.ts
│ │ │ │ ├── element-cap-bonus.ts