fix: createDefaultCombatState now uses discipline-aware channel stats
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
- Import computeChannelStats in combat-reset.ts - Replace hardcoded channelSpeedMultiplier/channelDrainRate with computed values - Fixes bug where resetCombat() lost discipline-modified channel stats - Add regression tests in combat-reset-channel-stats.test.ts
This commit is contained in:
@@ -1,14 +1,15 @@
|
||||
# Circular Dependencies
|
||||
Generated: 2026-06-15T08:59:04.077Z
|
||||
Found: 7 circular chain(s) — these MUST be fixed before modifying involved files.
|
||||
Generated: 2026-06-15T10:13:15.747Z
|
||||
Found: 8 circular chain(s) — these MUST be fixed before modifying involved files.
|
||||
|
||||
1. 1) data/guardian-encounters.ts > data/guardian-procedural.ts
|
||||
2. 2) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts
|
||||
3. 3) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts > stores/crafting-equipment-tick.ts
|
||||
4. 4) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts > stores/pipelines/equipment-crafting.ts
|
||||
5. 5) stores/golem-combat-actions.ts > stores/golem-combat-helpers.ts
|
||||
6. 6) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts
|
||||
7. 7) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts > stores/non-combat-room-actions.ts
|
||||
2. 2) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts
|
||||
3. 3) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts
|
||||
4. 4) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts > stores/crafting-equipment-tick.ts
|
||||
5. 5) stores/combatStore.ts > stores/combat-actions.ts > stores/combat-room-enchantments.ts > stores/craftingStore.ts > stores/pipelines/equipment-crafting.ts
|
||||
6. 6) stores/golem-combat-actions.ts > stores/golem-combat-helpers.ts
|
||||
7. 7) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts
|
||||
8. 8) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts > stores/non-combat-room-actions.ts
|
||||
|
||||
## How to fix
|
||||
1. Identify which import in the chain can be extracted to a shared types/utils file.
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"_meta": {
|
||||
"generated": "2026-06-15T08:59:01.387Z",
|
||||
"generated": "2026-06-15T10:13:13.518Z",
|
||||
"description": "Import dependency graph for src/lib/game. Keys are files, values are arrays of files they import.",
|
||||
"usage": "To find what a file affects, search for its path in the VALUES. To find what a file depends on, look at its KEY entry."
|
||||
},
|
||||
@@ -150,10 +150,6 @@
|
||||
"stores/craftingStore.types.ts",
|
||||
"types.ts"
|
||||
],
|
||||
"crafting-actions/disenchant-actions.ts": [
|
||||
"stores/craftingStore.types.ts",
|
||||
"stores/manaStore.ts"
|
||||
],
|
||||
"crafting-actions/equipment-actions.ts": [
|
||||
"crafting-utils.ts",
|
||||
"stores/craftingStore.types.ts",
|
||||
@@ -164,7 +160,6 @@
|
||||
"crafting-actions/computed-getters.ts",
|
||||
"crafting-actions/crafting-equipment-actions.ts",
|
||||
"crafting-actions/design-actions.ts",
|
||||
"crafting-actions/disenchant-actions.ts",
|
||||
"crafting-actions/equipment-actions.ts",
|
||||
"crafting-actions/preparation-actions.ts"
|
||||
],
|
||||
@@ -669,20 +664,16 @@
|
||||
"stores/craftingStore.ts": [
|
||||
"crafting-actions/application-actions.ts",
|
||||
"crafting-actions/crafting-material-actions.ts",
|
||||
"crafting-actions/design-actions.ts",
|
||||
"crafting-actions/equipment-actions.ts",
|
||||
"crafting-actions/preparation-actions.ts",
|
||||
"crafting-design.ts",
|
||||
"crafting-utils.ts",
|
||||
"effects/discipline-effects.ts",
|
||||
"effects/special-effects.ts",
|
||||
"effects/upgrade-effects.ts",
|
||||
"stores/attunementStore.ts",
|
||||
"stores/combatStore.ts",
|
||||
"stores/crafting-equipment-tick.ts",
|
||||
"stores/crafting-initial-state.ts",
|
||||
"stores/craftingStore.types.ts",
|
||||
"stores/manaStore.ts",
|
||||
"stores/pipelines/equipment-crafting.ts",
|
||||
"stores/uiStore.ts",
|
||||
"types/equipmentSlot.ts",
|
||||
"utils/result.ts",
|
||||
"utils/safe-persist.ts"
|
||||
|
||||
@@ -209,6 +209,7 @@ Mana-Loop/
|
||||
│ │ │ │ ├── bug-377-mana-auto-unlock.test.ts
|
||||
│ │ │ │ ├── bug-fixes.test.ts
|
||||
│ │ │ │ ├── combat-actions.test.ts
|
||||
│ │ │ │ ├── combat-reset-channel-stats.test.ts
|
||||
│ │ │ │ ├── combat-utils.test.ts
|
||||
│ │ │ │ ├── computed-stats.test.ts
|
||||
│ │ │ │ ├── conversion-pause-bug-regression.test.ts
|
||||
|
||||
Reference in New Issue
Block a user