fix: Remove problematic effects and ensure insight only gained on loop reset
All checks were successful
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m54s

- Remove armor pierce, mana equilibrium, perfect memory, free study, mind palace, elemental harmony, deep storage, double craft, pure elements
- Replace with balanced alternatives: first strike, flow mastery, quick grasp, efficient learning, deep understanding, elemental affinity, mana overflow, elemental surge, exotic mastery
- Remove insight-gaining effects (studyInsight, manaAscension, knowledgeOverflow, studyMastery)
- Ensure insight can ONLY be gained on loop reset
- Remove conversion-related upgrades (conversion not available to players)
- Fix duplicate effect IDs
This commit is contained in:
2026-03-27 13:55:26 +00:00
parent d0ecbfefd9
commit 8a62a4faaf
3 changed files with 85 additions and 25 deletions

View File

@@ -834,3 +834,65 @@ Stage Summary:
3. `constants.ts` - 862 lines - Split into domain files
4. `skill-evolution.ts` - 797 lines - Split into per-skill files
5. `crafting-slice.ts` - 795 lines - Split crafting from equipment
---
Task ID: 3
Agent: Main
Task: Remove problematic effects and ensure insight only gained on loop reset
Work Log:
- **Removed Effects from Skill Evolution**:
- `armorPierce` → Replaced with `firstStrike` (+15% damage on first attack each floor)
- `manaEquilibrium` → Replaced with `flowMastery` (+10% mana from all sources)
- `perfectMemory` → Replaced with `quickRecall` (halved study progress loss on cancel)
- `freeStudy` → Replaced with `efficientLearning` (-10% study mana cost)
- `mindPalace` → Replaced with `deepUnderstanding` (+10% bonus from all skill levels)
- `elementalHarmony` → Replaced with `elementMastery` (+10% element capacity)
- `deepStorage` → Replaced with `quickConversion` (+10% conversion speed)
- `doubleCraft` → Replaced with `elementalSurge` (+15% elemental damage)
- `pureElements` → Replaced with `exoticMastery` (+20% exotic element damage)
- **Removed Insight-Gaining Effects**:
- `studyInsight` → Replaced with `deepConcentration` (+20% study speed when mana > 90%)
- `manaAscension` → Changed to not give insight during loop (now +100% max mana when above 90% mana)
- `knowledgeOverflow` → Changed to carry progress to next study instead of giving insight
- `studyMastery` → Changed to give 25% mana back on study complete instead of insight
- **Updated SPECIAL_EFFECTS constant** in upgrade-effects.ts:
- Removed: ARMOR_PIERCE, MANA_EQUILIBRIUM, PERFECT_MEMORY, FREE_STUDY, MIND_PALACE, ELEMENTAL_HARMONY, DEEP_STORAGE, DOUBLE_CRAFT, PURE_ELEMENTS
- Added: FIRST_STRIKE, QUICK_RECALL, DEEP_CONCENTRATION, DEEP_UNDERSTANDING, EXOTIC_MASTERY
- **Verified Insight System**:
- Insight is ONLY gained at loop reset through `calcInsight()` function
- `insightAmp` and `insightHarvest` prestige upgrades only affect the multiplier for loop-end insight
- No other code paths directly add insight during gameplay
Stage Summary:
- All problematic effects removed and replaced with balanced alternatives
- Insight can now ONLY be gained on loop reset (no mid-loop insight gain)
- All lint checks pass
- Dev server running without errors
---
Task ID: 4
Agent: Main
Task: Fix additional problematic effect replacements
Work Log:
- **Fixed Quick Recall** - Study progress is already saved on cancel, so this was redundant
- Replaced with `Quick Grasp`: 5% chance for double study progress per hour
- **Fixed Quick Conversion** - Mana conversion is not available to players (no UI button)
- Replaced with `Elemental Affinity`: Newly unlocked elements start with 10 capacity
- **Fixed Mana Ascension** - "Extra max mana when above 90% mana" didn't make sense
- Replaced with `Mana Conduit`: Meditation also regenerates 5% max elemental mana per hour
- **Removed all conversion-related upgrades**:
- `Flow Conversion` (mf_t1_l5) → Replaced with `Mana Overflow`: Raw mana can exceed max by 20%
- `Efficient Conversion` (ea_t1_l5) → Replaced with `Elemental Surge`: +15% elemental damage
- **Fixed duplicate IDs**:
- Fixed `ea_t1_l5_expand2` used twice → Renamed second one to `ea_t1_l5_surge`
- Fixed `ea_t1_l10_surge` duplicate → Renamed to `ea_t1_l10_power`
- **Updated SPECIAL_EFFECTS constant**:
- Added: QUICK_GRASP, MANA_OVERFLOW, ELEMENTAL_AFFINITY, MANA_CONDUIT
Stage Summary:
- All replacement effects now make logical sense
- No conversion-related upgrades remain (conversion not available to players)
- No duplicate effect IDs
- All lint checks pass