Anexim/Mana-Loop
1
1
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve circular dependency in discipline-slice → discipline-effects
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
Details

Browse Source 
Replaced computeDisciplineEffects() import in discipline-slice.ts with
inline XP bonus calculation using calculateStatBonus from discipline-math.
This avoids the circular chain: discipline-effects → discipline-slice → discipline-effects.
This commit is contained in:
n8n-gitea
2026-05-28 09:47:45 +02:00
parent 8cebea9586
commit b5996d5b6e
3 changed files with 34 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/circular-deps.txt
+9 -2
View File
@@ -1,4 +1,11 @@
# Circular Dependencies
Generated: 2026-05-27T19:08:46.353Z
Generated: 2026-05-28T07:32:48.513Z
Found: 1 circular chain(s) — these MUST be fixed before modifying involved files.
No circular dependencies found. ✅
1. 1) effects/discipline-effects.ts > stores/discipline-slice.ts
## How to fix
1. Identify which import in the chain can be extracted to a shared types/utils file.
2. Move the shared type or function there.
3. Both files import from the new shared module instead of each other.
4. Run: bunx madge --circular src/lib/game (should return clean)