fix: resolve 22 remaining issues - type exports, dead code, state mutations, orphaned components

src/lib/game/effects/upgrade-effects.types.ts

@@ -1,13 +1,11 @@
 // ─── Upgrade Effect Types ────────────────────────────────────────────────────
 // Type interfaces for upgrade effects
 
-import type { SkillUpgradeChoice, SkillUpgradeEffect } from './types';
-
 export interface ActiveUpgradeEffect {
   upgradeId: string;
   skillId: string;
   milestone: 5 | 10;
-  effect: SkillUpgradeEffect;
+  effect: string;
   name: string;
   desc: string;
 }
@@ -23,7 +21,7 @@ export interface ComputedEffects {
   meditationEfficiency: number;
   spellCostMultiplier: number;
   conversionEfficiency: number;
-  
+
   // Combat effects
   baseDamageMultiplier: number;
   baseDamageBonus: number;
@@ -31,33 +29,33 @@ export interface ComputedEffects {
   critChanceBonus: number;
   critDamageMultiplier: number;
   elementalDamageMultiplier: number;
-  
+
   // Study effects
   studySpeedMultiplier: number;
   studyCostMultiplier: number;
   progressRetention: number;
   instantStudyChance: number;
   freeStudyChance: number;
-  
+
   // Element effects
   elementCapMultiplier: number;
   elementCapBonus: number;
   perElementCapBonus: Record<string, number>;
   conversionCostMultiplier: number;
   doubleCraftChance: number;
-  
+
   // Special values
   permanentRegenBonus: number;
-  
+
   // Special effect flags
   specials: Set<string>;
-  
+
   // All active upgrades for display
   activeUpgrades: ActiveUpgradeEffect[];
-  
+
   // DEEP_UNDERSTANDING: +10% bonus from all skill levels
   skillLevelMultiplier: number;
-  
+
   // Enchantment Power
   enchantmentPowerMultiplier: number;
 }