Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Cannot restart practicing a discipline after stopping it #163

New Issue
Closed
opened 2026-05-27 15:50:49 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-27 15:50:49 +02:00
Owner
Copy Link
Copy Source

Bug Description

After stopping a discipline (deactivating it), the player cannot start practicing it again. Clicking "Start Practicing" does nothing.

Steps to Reproduce

  1. Start practicing any discipline (e.g. Raw Mana Mastery)
  2. Stop practicing it
  3. Click "Start Practicing" again → nothing happens

Root Cause

In DisciplinesTab.tsx, the handleToggle callback calls activate(id, { elements, signedPacts }) but never passes rawMana in the gameState object.

In discipline-math.ts → canProceedDiscipline(), when the discipline's manaType is 'raw', it checks:

return (gameState.rawMana || 0) >= drain;

Since rawMana is undefined, this evaluates to 0 >= drainBase which is false for any discipline with drainBase > 0.

On first activation, disciplineState is undefined, so canProceedDiscipline short-circuits with return true. But after deactivation, the discipline state exists (with accumulated XP), so the mana check runs and silently fails.

Fix

Pass rawMana from the mana store into the gameState argument when calling activate in DisciplinesTab.tsx.

## Bug Description After stopping a discipline (deactivating it), the player cannot start practicing it again. Clicking "Start Practicing" does nothing. ## Steps to Reproduce 1. Start practicing any discipline (e.g. Raw Mana Mastery) 2. Stop practicing it 3. Click "Start Practicing" again → nothing happens ## Root Cause In `DisciplinesTab.tsx`, the `handleToggle` callback calls `activate(id, { elements, signedPacts })` but **never passes `rawMana`** in the gameState object. In `discipline-math.ts` → `canProceedDiscipline()`, when the discipline's `manaType` is `'raw'`, it checks: ```ts return (gameState.rawMana || 0) >= drain; ``` Since `rawMana` is `undefined`, this evaluates to `0 >= drainBase` which is `false` for any discipline with `drainBase > 0`. On first activation, `disciplineState` is `undefined`, so `canProceedDiscipline` short-circuits with `return true`. But after deactivation, the discipline state exists (with accumulated XP), so the mana check runs and silently fails. ## Fix Pass `rawMana` from the mana store into the `gameState` argument when calling `activate` in `DisciplinesTab.tsx`.
Anexim added the ai:in-progress label 2026-05-27 15:50:49 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 15:50:49 +02:00
Anexim commented 2026-05-27 15:55:45 +02:00
Author
Owner
Copy Link
Copy Source

Fix Applied

File changed: src/components/game/tabs/DisciplinesTab.tsx

Two changes:

  1. Added rawMana from useManaStore and passed it in the gameState object to activate()
  2. Fixed the useCallback dependency array to include rawMana and signedPacts (was missing both)

Root cause confirmed: canProceedDiscipline() in discipline-math.ts checks gameState.rawMana >= drain for raw mana disciplines. Since rawMana was never passed, it evaluated to 0 >= drainBase → false, silently blocking reactivation. First-time activation worked because disciplineState is undefined, which short-circuits the check.

Regression test added: src/lib/game/__tests__/discipline-reactivate-bug.test.ts — 4 tests covering:

  • Raw discipline reactivation (reproduces the bug without rawMana, verifies fix with it)
  • Element discipline reactivation
  • Reactivation after processTick auto-pause
  • XP preservation across deactivate/reactivate cycles

All 906 tests pass (47 files).

## Fix Applied **File changed:** `src/components/game/tabs/DisciplinesTab.tsx` **Two changes:** 1. Added `rawMana` from `useManaStore` and passed it in the `gameState` object to `activate()` 2. Fixed the `useCallback` dependency array to include `rawMana` and `signedPacts` (was missing both) **Root cause confirmed:** `canProceedDiscipline()` in `discipline-math.ts` checks `gameState.rawMana >= drain` for raw mana disciplines. Since `rawMana` was never passed, it evaluated to `0 >= drainBase` → `false`, silently blocking reactivation. First-time activation worked because `disciplineState` is `undefined`, which short-circuits the check. **Regression test added:** `src/lib/game/__tests__/discipline-reactivate-bug.test.ts` — 4 tests covering: - Raw discipline reactivation (reproduces the bug without `rawMana`, verifies fix with it) - Element discipline reactivation - Reactivation after processTick auto-pause - XP preservation across deactivate/reactivate cycles All 906 tests pass (47 files).
Anexim commented 2026-05-27 15:58:09 +02:00
Author
Owner
Copy Link
Copy Source

Fixed and pushed to master (commit 5f8a860). The fix passes rawMana from the mana store into the activate() call in DisciplinesTab, and fixes the useCallback dependency array to include rawMana and signedPacts. Regression tests added and all 906 tests pass.

Fixed and pushed to master (commit 5f8a860). The fix passes `rawMana` from the mana store into the `activate()` call in DisciplinesTab, and fixes the useCallback dependency array to include `rawMana` and `signedPacts`. Regression tests added and all 906 tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:in-progress
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?