Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 RAW MANA MASTERY perks: regenMultiplier missing from unified effects pipeline #166

New Issue
Closed
opened 2026-05-27 17:28:12 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-27 17:28:12 +02:00
Owner
Copy Link
Copy Source

Bug

Raw Mana Mastery and Mana Circulation perks seem very weak or non-functional. Investigation reveals:

Issue 1: regenMultiplier not in unified effects

The mana-circulation-regen perk adds regenMultiplier to disciplineEffects.multipliers. This is only applied in the tick pipeline (gameStore.ts:122) via a manual extra line. It is not merged in computeAllEffects() at effects.ts:131 — the unified effects regenMultiplier only includes upgradeEffects.regenMultiplier and equipmentEffects.multipliers.regen, missing the discipline contribution entirely.

This means:

  • Display hooks (gameHooks.ts:70, useGameDerived.ts:47) that use the unified path don't show the bonus
  • Any future code using computeAllEffects() will miss the discipline regen multiplier

Issue 2: Base values are numerically weak

regenBonus has baseValue: 0.2 with formula 0.2 * (XP/50)^0.65 — at 1000 XP, this is only 1.74 regen. The regenMultiplier perk adds +0.10 * tiers, starting from a tiny base.

Fix

  1. Merge disciplineEffects.multipliers.regenMultiplier into computeAllEffects() at effects.ts:131
  2. Consider increasing baseValue for regenBonus and regenMultiplier amount
  3. Fix display hooks to include discipline multiplers

Files

  • src/lib/game/effects.ts:131 (missing merge)
  • src/lib/game/stores/gameHooks.ts:70 (display hook)
  • src/lib/game/hooks/useGameDerived.ts:47 (display hook)
  • src/lib/game/data/disciplines/base.ts:53-68 (perk definitions)
## Bug Raw Mana Mastery and Mana Circulation perks seem very weak or non-functional. Investigation reveals: ### Issue 1: `regenMultiplier` not in unified effects The `mana-circulation-regen` perk adds `regenMultiplier` to `disciplineEffects.multipliers`. This is **only applied in the tick pipeline** (`gameStore.ts:122`) via a manual extra line. It is **not merged** in `computeAllEffects()` at `effects.ts:131` — the unified effects `regenMultiplier` only includes `upgradeEffects.regenMultiplier` and `equipmentEffects.multipliers.regen`, missing the discipline contribution entirely. This means: - **Display hooks** (`gameHooks.ts:70`, `useGameDerived.ts:47`) that use the unified path don't show the bonus - Any future code using `computeAllEffects()` will miss the discipline regen multiplier ### Issue 2: Base values are numerically weak `regenBonus` has `baseValue: 0.2` with formula `0.2 * (XP/50)^0.65` — at 1000 XP, this is only `1.74` regen. The `regenMultiplier` perk adds `+0.10 * tiers`, starting from a tiny base. ## Fix 1. Merge `disciplineEffects.multipliers.regenMultiplier` into `computeAllEffects()` at `effects.ts:131` 2. Consider increasing `baseValue` for `regenBonus` and `regenMultiplier` amount 3. Fix display hooks to include discipline multiplers ## Files - `src/lib/game/effects.ts:131` (missing merge) - `src/lib/game/stores/gameHooks.ts:70` (display hook) - `src/lib/game/hooks/useGameDerived.ts:47` (display hook) - `src/lib/game/data/disciplines/base.ts:53-68` (perk definitions)
Anexim added the ai:todo label 2026-05-27 17:28:12 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 17:28:12 +02:00
Anexim commented 2026-05-28 09:49:36 +02:00
Author
Owner
Copy Link
Copy Source

Fixed in commit 8cebea9. Merged disciplineEffects.multipliers.regenMultiplier into computeAllEffects() so the discipline regen multiplier is included in the unified effects pipeline.

Fixed in commit 8cebea9. Merged `disciplineEffects.multipliers.regenMultiplier` into `computeAllEffects()` so the discipline regen multiplier is included in the unified effects pipeline.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?