Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 PERK DESCRIPTIONS: Multiple perks have descriptions that don't match actual effects #168

New Issue
Closed
opened 2026-05-27 17:28:13 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-27 17:28:13 +02:00
Owner
Copy Link
Copy Source

Bug

Several perk descriptions are misleading or completely wrong — they describe effects that don't exist in code.

Perks That Do Nothing (Broken)

Perk File:Line Description Claims Code Actually Does
enchant-2 enchanter.ts:25 "Double enchantment duration at 300 XP" Nothing — no bonus, no unlocksEffects, just gets added to unused specials set
channel-1 enchanter.ts:45 "Unlock lightning mana boosting" Nothing — same dead specials pattern
golem-2 fabricator.ts:29 "Double golem capacity at 500 XP" Nothing — same dead specials pattern
efficiency-1 fabricator.ts:48 "Unlock reduced crafting costs" Nothing — same dead specials pattern

Perks With Misleading Descriptions

Perk File:Line Issue
enchant-1 enchanter.ts:24 Says "+5 Enchantment Power (stacks with skill tiers)" but fires every 5 XP (extremely aggressive)
Study Mana Enchantments discipline enchanter-utility.ts:51 Claims "Increase your max mana" but its statBonus.stat = 'maxMana' is not in KNOWN_BONUS_STATS — orphaned, never consumed

Root Cause Pattern

Perks with type: 'capped' or type: 'once' that have neither bonus nor unlocksEffects get their ID added to a specials Set in discipline-effects.ts (lines 84, 91, 97), but nothing in the game logic processes those special IDs.

Fix Options

  1. Implement the missing effects — wire up the specials set to actual game logic
  2. Fix descriptions — change text to match what actually happens (or what's intended)
  3. Break down discipline effects — each discipline's perks that land in specials need proper handlers

Files

  • src/lib/game/effects/discipline-effects.ts:77-110 (perk processing)
  • src/lib/game/data/disciplines/enchanter.ts:24-47
  • src/lib/game/data/disciplines/fabricator.ts:29-50
  • src/lib/game/data/disciplines/enchanter-utility.ts:49-53
## Bug Several perk descriptions are misleading or completely wrong — they describe effects that don't exist in code. ### Perks That Do Nothing (Broken) | Perk | File:Line | Description Claims | Code Actually Does | |------|----------|-------------------|-------------------| | `enchant-2` | `enchanter.ts:25` | "Double enchantment duration at 300 XP" | **Nothing** — no `bonus`, no `unlocksEffects`, just gets added to unused `specials` set | | `channel-1` | `enchanter.ts:45` | "Unlock lightning mana boosting" | **Nothing** — same dead `specials` pattern | | `golem-2` | `fabricator.ts:29` | "Double golem capacity at 500 XP" | **Nothing** — same dead `specials` pattern | | `efficiency-1` | `fabricator.ts:48` | "Unlock reduced crafting costs" | **Nothing** — same dead `specials` pattern | ### Perks With Misleading Descriptions | Perk | File:Line | Issue | |------|----------|-------| | `enchant-1` | `enchanter.ts:24` | Says "+5 Enchantment Power (stacks with skill tiers)" but fires every 5 XP (extremely aggressive) | | Study Mana Enchantments discipline | `enchanter-utility.ts:51` | Claims "Increase your max mana" but its `statBonus.stat = 'maxMana'` is **not in `KNOWN_BONUS_STATS`** — orphaned, never consumed | ### Root Cause Pattern Perks with `type: 'capped'` or `type: 'once'` that have **neither `bonus` nor `unlocksEffects`** get their ID added to a `specials` Set in `discipline-effects.ts` (lines 84, 91, 97), but nothing in the game logic processes those special IDs. ## Fix Options 1. **Implement the missing effects** — wire up the `specials` set to actual game logic 2. **Fix descriptions** — change text to match what actually happens (or what's intended) 3. **Break down discipline effects** — each discipline's perks that land in `specials` need proper handlers ## Files - `src/lib/game/effects/discipline-effects.ts:77-110` (perk processing) - `src/lib/game/data/disciplines/enchanter.ts:24-47` - `src/lib/game/data/disciplines/fabricator.ts:29-50` - `src/lib/game/data/disciplines/enchanter-utility.ts:49-53`
Anexim added the ai:todo label 2026-05-27 17:28:13 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 17:28:13 +02:00
Anexim commented 2026-05-28 09:49:35 +02:00
Author
Owner
Copy Link
Copy Source

Fixed in commit 8cebea9. Wired 4 broken perks with actual bonus effects: enchant-2 (+10 Enchantment Power/tier), channel-1 (+15 Lightning Mana Capacity), golem-2 (+1 Golem Capacity/tier), efficiency-1 (+10% Crafting Cost Reduction). Fixed enchant-1 interval (5→50) and study-mana-enchantments stat (maxMana→maxManaBonus).

Fixed in commit 8cebea9. Wired 4 broken perks with actual bonus effects: enchant-2 (+10 Enchantment Power/tier), channel-1 (+15 Lightning Mana Capacity), golem-2 (+1 Golem Capacity/tier), efficiency-1 (+10% Crafting Cost Reduction). Fixed enchant-1 interval (5→50) and study-mana-enchantments stat (maxMana→maxManaBonus).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?