Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

🗑️ BAN: Remove shield equipment — shields don't make sense in this game #171

New Issue
Closed
opened 2026-05-27 17:28:14 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-27 17:28:14 +02:00
Owner
Copy Link
Copy Source

Action Required

Shields need to be removed from the game entirely. They don't make sense in Mana Loop's design. The offHand slot should remain for non-shield items (e.g. metalSpellFocus catalyst).

Shield Equipment to Remove

All 4 shields in src/lib/game/data/equipment/shields.ts:

  • basicShield (Basic Shield)
  • reinforcedShield (Reinforced Shield)
  • runicShield (Runic Shield)
  • manaShield (Mana Shield)

Complete List of Changes Needed

  1. src/lib/game/data/equipment/shields.ts — Delete file or empty export
  2. src/lib/game/data/equipment/equipment-types-data.ts:13,25 — Remove SHIELD_EQUIPMENT import and spread
  3. src/lib/game/data/equipment/index.ts:38 — Remove shield re-export
  4. src/lib/game/data/equipment/types.ts:5 — Remove 'shield' from EquipmentCategory union
  5. src/lib/game/data/equipment/utils.ts:31 — Remove case 'shield': return ['offHand'];
  6. src/lib/game/data/crafting-recipes.ts:123-137 — Remove shieldBlueprint recipe
  7. src/lib/game/data/fabricator-physical-recipes.ts:100-119 — Remove runicShield and manaShield recipes
  8. src/components/game/tabs/CraftingTab/FabricatorSubTab.tsx:27-38 — Remove runicShield and manaShield from BRANCH_RECIPE_IDS, isWizardBranch, isPhysicalBranch
  9. src/components/game/LootInventory/icons.ts:6,14 — Remove Shield import and shield: Shield mapping
  10. AGENTS.md — Add "shields" to the Banned list alongside lifesteal, healing, and banned mana types

Do NOT Change

  • src/components/game/tabs/guardian-pacts-components.tsx — uses Shield icon from lucide-react as UI decoration, not shield equipment
  • offHand slot itself — needed for catalyst off-hand items

Note

No enchantment changes needed — enchantment category arrays don't include 'shield'.
No loot drop changes needed — shields aren't in any loot tables.

## Action Required Shields need to be removed from the game entirely. They don't make sense in Mana Loop's design. The `offHand` slot should remain for non-shield items (e.g. `metalSpellFocus` catalyst). ## Shield Equipment to Remove All 4 shields in `src/lib/game/data/equipment/shields.ts`: - `basicShield` (Basic Shield) - `reinforcedShield` (Reinforced Shield) - `runicShield` (Runic Shield) - `manaShield` (Mana Shield) ## Complete List of Changes Needed 1. **`src/lib/game/data/equipment/shields.ts`** — Delete file or empty export 2. **`src/lib/game/data/equipment/equipment-types-data.ts:13,25`** — Remove `SHIELD_EQUIPMENT` import and spread 3. **`src/lib/game/data/equipment/index.ts:38`** — Remove shield re-export 4. **`src/lib/game/data/equipment/types.ts:5`** — Remove `'shield'` from `EquipmentCategory` union 5. **`src/lib/game/data/equipment/utils.ts:31`** — Remove `case 'shield': return ['offHand'];` 6. **`src/lib/game/data/crafting-recipes.ts:123-137`** — Remove `shieldBlueprint` recipe 7. **`src/lib/game/data/fabricator-physical-recipes.ts:100-119`** — Remove `runicShield` and `manaShield` recipes 8. **`src/components/game/tabs/CraftingTab/FabricatorSubTab.tsx:27-38`** — Remove `runicShield` and `manaShield` from `BRANCH_RECIPE_IDS`, `isWizardBranch`, `isPhysicalBranch` 9. **`src/components/game/LootInventory/icons.ts:6,14`** — Remove `Shield` import and `shield: Shield` mapping 10. **`AGENTS.md`** — Add "shields" to the Banned list alongside lifesteal, healing, and banned mana types ## Do NOT Change - `src/components/game/tabs/guardian-pacts-components.tsx` — uses Shield icon from lucide-react as UI decoration, not shield equipment - `offHand` slot itself — needed for catalyst off-hand items ## Note No enchantment changes needed — enchantment category arrays don't include `'shield'`. No loot drop changes needed — shields aren't in any loot tables.
Anexim added the ai:todo label 2026-05-27 17:28:14 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 17:28:14 +02:00
Anexim commented 2026-05-28 09:49:36 +02:00
Author
Owner
Copy Link
Copy Source

Fixed in commit 8cebea9. Removed all shield equipment (4 types), recipes (shieldBlueprint, runicShield, manaShield), category ('shield' from EquipmentCategory), slot mappings, and inventory icons. Added 'shields' to AGENTS.md banned list. 10 files changed.

Fixed in commit 8cebea9. Removed all shield equipment (4 types), recipes (shieldBlueprint, runicShield, manaShield), category ('shield' from EquipmentCategory), slot mappings, and inventory icons. Added 'shields' to AGENTS.md banned list. 10 files changed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#171
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?