[priority: high] Discipline tab doesn't show component names when "Show Component Names" debug flag is on #178

Closed
opened 2026-05-28 11:39:13 +02:00 by Anexim · 1 comment
Owner

Description

Every game tab in Mana Loop supports a "Show Component Names" debug flag (persisted to localStorage) that wraps the tab in a <DebugName> component, showing small yellow labels with component names in the top-left of each section. The DisciplinesTab is the only tab that does not implement this.

Root Cause

src/components/game/tabs/DisciplinesTab.tsx is missing:

  1. The import of DebugName from @/components/game/debug/debug-context
  2. Wrapping its root JSX return with <DebugName name="DisciplinesTab">

Every other tab (CraftingTab, AttunementsTab, EquipmentTab, PrestigeTab, etc.) follows this pattern.

Affected Files

  • src/components/game/tabs/DisciplinesTab.tsx — missing DebugName import and wrapper around root <div> at line ~261

Reproduction

  1. Enable "Show Component Names" in Debug tab
  2. Open various tabs — yellow component name labels appear
  3. Open Disciplines tab — no labels appear

Expected Behavior

DisciplinesTab should show "DisciplinesTab" label (and optionally individual discipline card labels) when the debug flag is enabled.

## Description Every game tab in Mana Loop supports a "Show Component Names" debug flag (persisted to localStorage) that wraps the tab in a `<DebugName>` component, showing small yellow labels with component names in the top-left of each section. The DisciplinesTab is the **only tab** that does not implement this. ## Root Cause `src/components/game/tabs/DisciplinesTab.tsx` is missing: 1. The import of `DebugName` from `@/components/game/debug/debug-context` 2. Wrapping its root JSX return with `<DebugName name="DisciplinesTab">` Every other tab (CraftingTab, AttunementsTab, EquipmentTab, PrestigeTab, etc.) follows this pattern. ## Affected Files - `src/components/game/tabs/DisciplinesTab.tsx` — missing `DebugName` import and wrapper around root `<div>` at line ~261 ## Reproduction 1. Enable "Show Component Names" in Debug tab 2. Open various tabs — yellow component name labels appear 3. Open Disciplines tab — no labels appear ## Expected Behavior DisciplinesTab should show "DisciplinesTab" label (and optionally individual discipline card labels) when the debug flag is enabled.
Anexim added the ai:todo label 2026-05-28 11:39:13 +02:00
n8n-gitea was assigned by Anexim 2026-05-28 11:39:13 +02:00
Author
Owner

Fix Applied

Added DebugName wrapper to DisciplinesTab.tsx:

  1. Added import: import { DebugName } from '@/components/game/debug/debug-context';
  2. Wrapped root JSX: Wrapped the return <div className="mt-6"> with <DebugName name="DisciplinesTab">...</DebugName>

This follows the exact same pattern used by every other tab (CraftingTab, AttunementsTab, EquipmentTab, PrestigeTab, etc.).

All pre-commit checks passed. File size: 315 lines (under 400 limit).

## Fix Applied Added `DebugName` wrapper to `DisciplinesTab.tsx`: 1. **Added import**: `import { DebugName } from '@/components/game/debug/debug-context';` 2. **Wrapped root JSX**: Wrapped the return `<div className="mt-6">` with `<DebugName name="DisciplinesTab">...</DebugName>` This follows the exact same pattern used by every other tab (CraftingTab, AttunementsTab, EquipmentTab, PrestigeTab, etc.). All pre-commit checks passed. File size: 315 lines (under 400 limit).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#178