[priority: medium] No non-weapon enchantment effect disciplines in Enchanter tab #190

New Issue

2026-05-28T15:57:24+02:00

Anexim commented

2026-05-28 15:57:24 +02:00

Bug: Enchanter disciplines only cover weapon enchantments, missing utility/mana/spell/special

Description

The Enchanter tab in Disciplines only shows 4 disciplines from enchanter.ts:

Enchantment Crafting
Mana Channeling
Study Basic Weapon Enchantments
Study Advanced Weapon Enchantments

But there are additional enchanter discipline files that are NOT included in the Enchanter tab:

enchanter-utility.ts — "Study Utility Enchantments" and "Study Mana Enchantments"
enchanter-spells.ts — "Study Basic/Intermediate/Advanced Spell Enchantments"
enchanter-special.ts — "Study Special Enchantments"

Root Cause Analysis

In DisciplinesTab.tsx, the ATTUNEMENT_TABS array only includes enchanterDisciplines:

{ key: 'enchanter', label: 'Enchanter', items: enchanterDisciplines },

It does NOT include:

enchanterUtilityDisciplines
enchanterSpellDisciplines
enchanterSpecialDisciplines

These ARE exported from data/disciplines/index.ts and included in ALL_DISCIPLINES, so they exist in the data. They're just not displayed in the Enchanter tab.

Affected Files

src/components/game/tabs/DisciplinesTab.tsx — ATTUNEMENT_TABS definition (line ~33)

Steps to Reproduce

Open Disciplines tab
Click "Enchanter" subtab
Observe only 4 disciplines shown
Note that utility, mana, spell, and special enchantment studies are missing

Expected Behavior

The Enchanter tab should show ALL enchanter-related disciplines, organized logically:

Core: Enchantment Crafting, Mana Channeling
Weapon: Study Basic Weapon Enchantments, Study Advanced Weapon Enchantments
Utility: Study Utility Enchantments, Study Mana Enchantments
Spells: Study Basic/Intermediate/Advanced Spell Enchantments
Special: Study Special Enchantments

Suggested Fix Direction

Add all enchanter discipline arrays to the Enchanter tab items
Consider adding sub-grouping or visual separation for the different categories
Ensure the tab doesn't become too long (may need scrolling or collapsible sections)

## Bug: Enchanter disciplines only cover weapon enchantments, missing utility/mana/spell/special ### Description The Enchanter tab in Disciplines only shows 4 disciplines from `enchanter.ts`: 1. Enchantment Crafting 2. Mana Channeling 3. Study Basic Weapon Enchantments 4. Study Advanced Weapon Enchantments But there are additional enchanter discipline files that are NOT included in the Enchanter tab: - `enchanter-utility.ts` — "Study Utility Enchantments" and "Study Mana Enchantments" - `enchanter-spells.ts` — "Study Basic/Intermediate/Advanced Spell Enchantments" - `enchanter-special.ts` — "Study Special Enchantments" ### Root Cause Analysis In `DisciplinesTab.tsx`, the `ATTUNEMENT_TABS` array only includes `enchanterDisciplines`: ```ts { key: 'enchanter', label: 'Enchanter', items: enchanterDisciplines }, ``` It does NOT include: - `enchanterUtilityDisciplines` - `enchanterSpellDisciplines` - `enchanterSpecialDisciplines` These ARE exported from `data/disciplines/index.ts` and included in `ALL_DISCIPLINES`, so they exist in the data. They're just not displayed in the Enchanter tab. ### Affected Files - `src/components/game/tabs/DisciplinesTab.tsx` — `ATTUNEMENT_TABS` definition (line ~33) ### Steps to Reproduce 1. Open Disciplines tab 2. Click "Enchanter" subtab 3. Observe only 4 disciplines shown 4. Note that utility, mana, spell, and special enchantment studies are missing ### Expected Behavior The Enchanter tab should show ALL enchanter-related disciplines, organized logically: - Core: Enchantment Crafting, Mana Channeling - Weapon: Study Basic Weapon Enchantments, Study Advanced Weapon Enchantments - Utility: Study Utility Enchantments, Study Mana Enchantments - Spells: Study Basic/Intermediate/Advanced Spell Enchantments - Special: Study Special Enchantments ### Suggested Fix Direction 1. Add all enchanter discipline arrays to the Enchanter tab items 2. Consider adding sub-grouping or visual separation for the different categories 3. Ensure the tab doesn't become too long (may need scrolling or collapsible sections)

Anexim added the ai:todo label 2026-05-28 15:57:24 +02:00

n8n-gitea was assigned by Anexim

2026-05-28 15:57:25 +02:00

n8n-gitea referenced this issue from a commit

2026-05-28 21:01:40 +02:00

fix: resolve issues #188, #189, #190, #191 - EffectSelector gating, discipline tab completeness, and stat bonus integration

Anexim closed this issue

2026-05-28 21:02:07 +02:00

Anexim commented

2026-05-28 21:02:07 +02:00

✅ Fixed. DisciplinesTab.tsx now includes all 4 enchanter discipline arrays in the Enchanter tab:

enchanterDisciplines (Enchantment Crafting, Mana Channeling, Basic/Advanced Weapon Enchantments)
enchanterUtilityDisciplines (Study Utility Enchantments, Study Mana Enchantments)
enchanterSpellDisciplines (Study Basic/Intermediate/Advanced Spell Enchantments)
enchanterSpecialDisciplines (Study Special Enchantments)

✅ Fixed. `DisciplinesTab.tsx` now includes all 4 enchanter discipline arrays in the Enchanter tab: - `enchanterDisciplines` (Enchantment Crafting, Mana Channeling, Basic/Advanced Weapon Enchantments) - `enchanterUtilityDisciplines` (Study Utility Enchantments, Study Mana Enchantments) - `enchanterSpellDisciplines` (Study Basic/Intermediate/Advanced Spell Enchantments) - `enchanterSpecialDisciplines` (Study Special Enchantments)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#190