Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[priority: medium] Enchanter disciplines need audit — verify all work and add value #191

New Issue
Closed
opened 2026-05-28 15:57:25 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-28 15:57:25 +02:00
Owner
Copy Link
Copy Source

Task: Audit all Enchanter disciplines for correctness and value

Description

The enchanter disciplines need a thorough review to ensure:

  1. All disciplines are listed in the Discipline tab (see related issue #7)
  2. All stat bonuses map to keys consumed by computeDisciplineEffects()
  3. All perks with unlocksEffects reference valid effect IDs
  4. Each discipline provides meaningful value for an enchanter playstyle

Current State

enchanter.ts (4 disciplines):

  • enchant-crafting → stat: 'enchantPower' ✓ (in KNOWN_BONUS_STATS)
  • mana-channeling → stat: 'clickManaMultiplier' ✗ (NOT in KNOWN_BONUS_STATS — this is a new key not handled anywhere)
  • study-basic-weapon-enchantments → stat: 'enchantPower' ✓
  • study-advanced-weapon-enchantments → stat: 'enchantPower' ✓

enchanter-utility.ts (2 disciplines):

  • study-utility-enchantments → stat: 'studySpeed' ✗ (NOT in KNOWN_BONUS_STATS)
  • study-mana-enchantments → stat: 'maxManaBonus' ✓

enchanter-spells.ts (3 disciplines):

  • study-basic-spell-enchantments → stat: 'enchantPower' ✓
  • study-intermediate-spell-enchantments → stat: 'enchantPower' ✓
  • study-advanced-spell-enchantments → stat: 'enchantPower' ✓

enchanter-special.ts (1 discipline):

  • study-special-enchantments → stat: 'enchantPower' ✓

Issues Found

  1. clickManaMultiplier stat: Used by mana-channeling discipline but not in KNOWN_BONUS_STATS in discipline-effects.ts. This means the bonus is computed but may not flow into the unified effects system correctly.

  2. studySpeed stat: Used by study-utility-enchantments but not in KNOWN_BONUS_STATS. Same issue.

  3. Perk unlocksEffects IDs: Need to verify all referenced effect IDs exist in ENCHANTMENT_EFFECTS:

    • sword_fire, sword_frost, sword_lightning, sword_void — ✓ (in elemental-effects.ts)
    • damage_5, crit_5, attack_speed_10 — ✓ (in combat-effects.ts)
    • meditate_10, study_10, insight_5 — ✓ (in utility-effects.ts)
    • mana_cap_50, mana_cap_100, mana_regen_1, mana_regen_2, click_mana_1, click_mana_3 — ✓ (in mana-effects.ts)
    • spell_manaBolt, spell_fireball, etc. — ✓ (in spell-effects/)
    • spell_echo_10, guardian_dmg_10, overpower_80, first_strike, combo_master, adrenaline_rush — ✓ (in special-effects.ts)

  4. Missing disciplines in Enchanter tab: enchanter-utility.ts, enchanter-spells.ts, enchanter-special.ts disciplines are not shown (see issue #7)

Affected Files

  • src/lib/game/data/disciplines/enchanter.ts
  • src/lib/game/data/disciplines/enchanter-utility.ts
  • src/lib/game/data/disciplines/enchanter-spells.ts
  • src/lib/game/data/disciplines/enchanter-special.ts
  • src/lib/game/effects/discipline-effects.ts — KNOWN_BONUS_STATS set

Steps to Audit

  1. Check each discipline's statBonus.stat is consumed somewhere in the effects pipeline
  2. Verify each unlocksEffects ID exists in ENCHANTMENT_EFFECTS
  3. Ensure each discipline provides unique, non-overlapping value
  4. Test that activating each discipline produces the expected in-game effect

Expected Outcome

  • All enchanter disciplines should be visible in the Discipline tab
  • All stat bonuses should flow into the unified effects system
  • All perk unlocks should grant the expected enchantment effects
  • Each discipline should have a clear purpose for enchanter gameplay

Suggested Fix Direction

  1. Add missing stat keys (clickManaMultiplier, studySpeed) to KNOWN_BONUS_STATS or handle them in computeDisciplineEffects()
  2. Add missing discipline arrays to the Enchanter tab
  3. Add tests verifying discipline → effect unlock flow
## Task: Audit all Enchanter disciplines for correctness and value ### Description The enchanter disciplines need a thorough review to ensure: 1. All disciplines are listed in the Discipline tab (see related issue #7) 2. All stat bonuses map to keys consumed by `computeDisciplineEffects()` 3. All perks with `unlocksEffects` reference valid effect IDs 4. Each discipline provides meaningful value for an enchanter playstyle ### Current State **enchanter.ts** (4 disciplines): - `enchant-crafting` → `stat: 'enchantPower'` ✓ (in KNOWN_BONUS_STATS) - `mana-channeling` → `stat: 'clickManaMultiplier'` ✗ (NOT in KNOWN_BONUS_STATS — this is a new key not handled anywhere) - `study-basic-weapon-enchantments` → `stat: 'enchantPower'` ✓ - `study-advanced-weapon-enchantments` → `stat: 'enchantPower'` ✓ **enchanter-utility.ts** (2 disciplines): - `study-utility-enchantments` → `stat: 'studySpeed'` ✗ (NOT in KNOWN_BONUS_STATS) - `study-mana-enchantments` → `stat: 'maxManaBonus'` ✓ **enchanter-spells.ts** (3 disciplines): - `study-basic-spell-enchantments` → `stat: 'enchantPower'` ✓ - `study-intermediate-spell-enchantments` → `stat: 'enchantPower'` ✓ - `study-advanced-spell-enchantments` → `stat: 'enchantPower'` ✓ **enchanter-special.ts** (1 discipline): - `study-special-enchantments` → `stat: 'enchantPower'` ✓ ### Issues Found 1. **`clickManaMultiplier` stat**: Used by `mana-channeling` discipline but not in `KNOWN_BONUS_STATS` in `discipline-effects.ts`. This means the bonus is computed but may not flow into the unified effects system correctly. 2. **`studySpeed` stat**: Used by `study-utility-enchantments` but not in `KNOWN_BONUS_STATS`. Same issue. 3. **Perk `unlocksEffects` IDs**: Need to verify all referenced effect IDs exist in `ENCHANTMENT_EFFECTS`: - `sword_fire`, `sword_frost`, `sword_lightning`, `sword_void` — ✓ (in `elemental-effects.ts`) - `damage_5`, `crit_5`, `attack_speed_10` — ✓ (in `combat-effects.ts`) - `meditate_10`, `study_10`, `insight_5` — ✓ (in `utility-effects.ts`) - `mana_cap_50`, `mana_cap_100`, `mana_regen_1`, `mana_regen_2`, `click_mana_1`, `click_mana_3` — ✓ (in `mana-effects.ts`) - `spell_manaBolt`, `spell_fireball`, etc. — ✓ (in `spell-effects/`) - `spell_echo_10`, `guardian_dmg_10`, `overpower_80`, `first_strike`, `combo_master`, `adrenaline_rush` — ✓ (in `special-effects.ts`) 4. **Missing disciplines in Enchanter tab**: `enchanter-utility.ts`, `enchanter-spells.ts`, `enchanter-special.ts` disciplines are not shown (see issue #7) ### Affected Files - `src/lib/game/data/disciplines/enchanter.ts` - `src/lib/game/data/disciplines/enchanter-utility.ts` - `src/lib/game/data/disciplines/enchanter-spells.ts` - `src/lib/game/data/disciplines/enchanter-special.ts` - `src/lib/game/effects/discipline-effects.ts` — `KNOWN_BONUS_STATS` set ### Steps to Audit 1. Check each discipline's `statBonus.stat` is consumed somewhere in the effects pipeline 2. Verify each `unlocksEffects` ID exists in `ENCHANTMENT_EFFECTS` 3. Ensure each discipline provides unique, non-overlapping value 4. Test that activating each discipline produces the expected in-game effect ### Expected Outcome - All enchanter disciplines should be visible in the Discipline tab - All stat bonuses should flow into the unified effects system - All perk unlocks should grant the expected enchantment effects - Each discipline should have a clear purpose for enchanter gameplay ### Suggested Fix Direction 1. Add missing stat keys (`clickManaMultiplier`, `studySpeed`) to `KNOWN_BONUS_STATS` or handle them in `computeDisciplineEffects()` 2. Add missing discipline arrays to the Enchanter tab 3. Add tests verifying discipline → effect unlock flow
Anexim added the ai:todo label 2026-05-28 15:57:25 +02:00
n8n-gitea was assigned by Anexim 2026-05-28 15:57:25 +02:00
Anexim commented 2026-05-28 21:02:08 +02:00
Author
Owner
Copy Link
Copy Source

✅ Fixed. Added missing stat keys and wired them into the unified effects system:

  1. Added clickManaMultiplier and studySpeed to KNOWN_BONUS_STATS in discipline-effects.ts
  2. Wired disciplineEffects.bonuses.clickManaMultiplier into computeAllEffects() → clickManaMultiplier merge (multiplicative: * (1 + bonus))
  3. Wired disciplineEffects.bonuses.studySpeed into computeAllEffects() → studySpeedMultiplier merge (multiplicative: * (1 + bonus))

Now the mana-channeling discipline's clickManaMultiplier bonus and the study-utility-enchantments discipline's studySpeed bonus properly flow into the unified effects system.

✅ Fixed. Added missing stat keys and wired them into the unified effects system: 1. Added `clickManaMultiplier` and `studySpeed` to `KNOWN_BONUS_STATS` in `discipline-effects.ts` 2. Wired `disciplineEffects.bonuses.clickManaMultiplier` into `computeAllEffects()` → `clickManaMultiplier` merge (multiplicative: `* (1 + bonus)`) 3. Wired `disciplineEffects.bonuses.studySpeed` into `computeAllEffects()` → `studySpeedMultiplier` merge (multiplicative: `* (1 + bonus)`) Now the `mana-channeling` discipline's clickManaMultiplier bonus and the `study-utility-enchantments` discipline's studySpeed bonus properly flow into the unified effects system.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?