Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

BUG: Raw mana exceeds max cap (111.8 / 100) #237

New Issue
Closed
opened 2026-06-01 09:22:36 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-01 09:22:36 +02:00
Owner
Copy Link
Copy Source

Bug Description

Raw mana pool is not being clamped to its maximum value. The debug panel shows Current: 111.85941260450063 / 100, meaning mana is ~11.8% over the cap. This allows unbounded mana accumulation beyond the intended limit.

Steps to Reproduce

  1. Play the game normally (gather mana, meditate, level up discipline)
  2. Check the Debug panel → Mana Debug section
  3. Observe mana value exceeds the displayed max of 100

Expected Behavior

Mana should be clamped to maxMana after each tick/regen cycle.

Impact

  • Game balance issue — player accumulates more mana than intended
  • May cause overflow issues in downstream calculations
## Bug Description Raw mana pool is not being clamped to its maximum value. The debug panel shows `Current: 111.85941260450063 / 100`, meaning mana is ~11.8% over the cap. This allows unbounded mana accumulation beyond the intended limit. ## Steps to Reproduce 1. Play the game normally (gather mana, meditate, level up discipline) 2. Check the Debug panel → Mana Debug section 3. Observe mana value exceeds the displayed max of 100 ## Expected Behavior Mana should be clamped to maxMana after each tick/regen cycle. ## Impact - Game balance issue — player accumulates more mana than intended - May cause overflow issues in downstream calculations
Anexim added the ai:todo label 2026-06-01 09:22:36 +02:00
n8n-gitea was assigned by Anexim 2026-06-01 09:22:36 +02:00
Anexim commented 2026-06-01 09:51:39 +02:00
Author
Owner
Copy Link
Copy Source

Investigation Complete — Issue is Incorrect

After thorough investigation using parallel agents, the bug described in this issue is not a mana cap breach. The mana is NOT exceeding the actual max cap — the debug panel is displaying the wrong max mana value.

Root Cause

The debug panel in GameStateDebugSection.tsx (and the legacy GameStateDebug.tsx) called computeMaxMana() with empty parameters:

const maxMana = computeMaxMana(
  { skills: {}, prestigeUpgrades: {}, skillUpgrades: {}, skillTiers: {} }
);

This always returned the base value of 100, ignoring:

  • Prestige upgrades (manaWell adds +500 per level)
  • Discipline bonuses (e.g., raw-mastery gives +10 baseValue maxManaBonus, with perks adding more)
  • Equipment enchantment bonuses (maxManaBonus from gear)
  • Multiplicative effects (maxManaMultiplier)

The actual game display in LeftPanel.tsx correctly uses computeTotalMaxMana() which aggregates all these sources. With discipline bonuses, the real max mana was likely ~111.8, so raw mana was exactly at the real cap — not over it.

Fix Applied

Both debug files have been updated to:

  1. Import computeTotalMaxMana and getUnifiedEffects from @/lib/game/effects
  2. Pull real prestigeUpgrades, equippedInstances, and equipmentInstances from the actual stores
  3. Compute max mana using the full formula identical to LeftPanel.tsx

Files changed:

  • src/components/game/tabs/DebugTab/GameStateDebugSection.tsx (active debug panel)
  • src/components/game/debug/GameStateDebug.tsx (legacy debug panel)

Tests: All 900 tests pass (44 test files).

## Investigation Complete — Issue is Incorrect After thorough investigation using parallel agents, the bug described in this issue is **not a mana cap breach**. The mana is NOT exceeding the actual max cap — the debug panel is displaying the **wrong max mana value**. ### Root Cause The debug panel in `GameStateDebugSection.tsx` (and the legacy `GameStateDebug.tsx`) called `computeMaxMana()` with **empty parameters**: ```ts const maxMana = computeMaxMana( { skills: {}, prestigeUpgrades: {}, skillUpgrades: {}, skillTiers: {} } ); ``` This always returned the base value of **100**, ignoring: - Prestige upgrades (`manaWell` adds +500 per level) - Discipline bonuses (e.g., `raw-mastery` gives +10 baseValue maxManaBonus, with perks adding more) - Equipment enchantment bonuses (`maxManaBonus` from gear) - Multiplicative effects (`maxManaMultiplier`) The actual game display in `LeftPanel.tsx` correctly uses `computeTotalMaxMana()` which aggregates all these sources. With discipline bonuses, the real max mana was likely ~111.8, so raw mana was exactly at the real cap — not over it. ### Fix Applied Both debug files have been updated to: 1. Import `computeTotalMaxMana` and `getUnifiedEffects` from `@/lib/game/effects` 2. Pull real `prestigeUpgrades`, `equippedInstances`, and `equipmentInstances` from the actual stores 3. Compute max mana using the full formula identical to `LeftPanel.tsx` **Files changed:** - `src/components/game/tabs/DebugTab/GameStateDebugSection.tsx` (active debug panel) - `src/components/game/debug/GameStateDebug.tsx` (legacy debug panel) **Tests:** All 900 tests pass (44 test files).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?