Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: grimoire property on SpellDef raw-spells but not in type definition #25

New Issue
Closed
opened 2026-05-18 15:54:41 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 15:54:41 +02:00
Owner
Copy Link
Copy Source

Severity: Critical

Files:

  • src/lib/game/constants/spells-modules/raw-spells.ts (lines 17, 29) — grimoire: true on manaBolt and manaStrike
  • src/lib/game/types/spells.ts — SpellDef interface does not include grimoire

Problem: Two raw spells have a grimoire: true property, but the SpellDef interface in types/spells.ts does not define this property. TypeScript will flag this as an excess property error.

Impact: Type error when defining raw spells. The grimoire flag has no effect on any game logic since it's only set but never read.

Fix: Either add grimoire?: boolean to the SpellDef interface, or remove the property from raw-spells.ts if it's unused dead code.

**Severity:** Critical **Files:** - `src/lib/game/constants/spells-modules/raw-spells.ts` (lines 17, 29) — `grimoire: true` on `manaBolt` and `manaStrike` - `src/lib/game/types/spells.ts` — `SpellDef` interface does not include `grimoire` **Problem:** Two raw spells have a `grimoire: true` property, but the `SpellDef` interface in `types/spells.ts` does not define this property. TypeScript will flag this as an excess property error. **Impact:** Type error when defining raw spells. The `grimoire` flag has no effect on any game logic since it's only set but never read. **Fix:** Either add `grimoire?: boolean` to the `SpellDef` interface, or remove the property from `raw-spells.ts` if it's unused dead code.
Anexim added the ai:todo label 2026-05-18 15:54:41 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:54:41 +02:00
Anexim commented 2026-05-18 20:38:14 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on grimoire property on SpellDef not in type definition

Starting work on grimoire property on SpellDef not in type definition
Anexim commented 2026-05-18 20:42:02 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Added grimoire?: boolean to SpellDef interface in types/spells.ts

Fixed: Added grimoire?: boolean to SpellDef interface in types/spells.ts
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#25
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?