Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Debug discipline XP buttons don't update totalXP or concurrentLimit #253

New Issue
Closed
opened 2026-06-01 15:07:38 +02:00 by Anexim · 2 comments
Anexim commented 2026-06-01 15:07:38 +02:00
Owner
Copy Link
Copy Source

Steps to reproduce:

  1. Open Debug tab → Disciplines section
  2. Click "+1K" on any discipline (e.g., Raw Mana Mastery)
  3. Observe "Active: X / Y" display

Expected: After adding 1000 XP, concurrentLimit should increase from 1 to 3 (formula: 1 + floor(totalXP / 500), max 4). With 2000+ total XP, limit should be 3.

Actual: "Active: 1 / 1" stays at limit 1 regardless of how much XP is added. The concurrentLimit never updates.

Root cause: The handleAddXP function in DisciplineDebugSection.tsx updates discipline XP directly via useDisciplineStore.setState(), but it only modifies disciplines[id].xp. It does NOT update totalXP or recalculate concurrentLimit. These values are only updated during processTick() in the discipline store, which only runs during the game tick loop (every 200ms). Since the game was paused during testing, no ticks fired.

Fix: In handleAddXP, also update totalXP by the same amount, and recalculate concurrentLimit using the formula Math.min(MAX_CONCURRENT_DISCIPLINES + Math.floor(newTotalXP / 500), MAX_CONCURRENT_DISCIPLINES + 3).

Affected file: src/components/game/tabs/DebugTab/DisciplineDebugSection.tsx (the handleAddXP function)

Store: useDisciplineStore (disciplines, totalXP, concurrentLimit)

**Steps to reproduce:** 1. Open Debug tab → Disciplines section 2. Click "+1K" on any discipline (e.g., Raw Mana Mastery) 3. Observe "Active: X / Y" display **Expected:** After adding 1000 XP, `concurrentLimit` should increase from 1 to 3 (formula: `1 + floor(totalXP / 500)`, max 4). With 2000+ total XP, limit should be 3. **Actual:** "Active: 1 / 1" stays at limit 1 regardless of how much XP is added. The `concurrentLimit` never updates. **Root cause:** The `handleAddXP` function in `DisciplineDebugSection.tsx` updates discipline XP directly via `useDisciplineStore.setState()`, but it only modifies `disciplines[id].xp`. It does NOT update `totalXP` or recalculate `concurrentLimit`. These values are only updated during `processTick()` in the discipline store, which only runs during the game tick loop (every 200ms). Since the game was paused during testing, no ticks fired. **Fix:** In `handleAddXP`, also update `totalXP` by the same amount, and recalculate `concurrentLimit` using the formula `Math.min(MAX_CONCURRENT_DISCIPLINES + Math.floor(newTotalXP / 500), MAX_CONCURRENT_DISCIPLINES + 3)`. **Affected file:** `src/components/game/tabs/DebugTab/DisciplineDebugSection.tsx` (the `handleAddXP` function) **Store:** `useDisciplineStore` (disciplines, totalXP, concurrentLimit)
Anexim added the ai:todo label 2026-06-01 15:07:38 +02:00
n8n-gitea was assigned by Anexim 2026-06-01 15:07:38 +02:00
Anexim commented 2026-06-02 12:01:25 +02:00
Author
Owner
Copy Link
Copy Source

Starting fix. handleAddXP in DisciplineDebugSection.tsx only updates disciplines[id].xp but not totalXP or concurrentLimit. Fix: also update totalXP and recalculate concurrentLimit using the same formula as processTick.

Starting fix. handleAddXP in DisciplineDebugSection.tsx only updates disciplines[id].xp but not totalXP or concurrentLimit. Fix: also update totalXP and recalculate concurrentLimit using the same formula as processTick.
Anexim commented 2026-06-02 12:03:32 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: handleAddXP in DisciplineDebugSection.tsx now updates totalXP and recalculates concurrentLimit alongside disciplines[id].xp. The formula matches processTick: Math.min(MAX_CONCURRENT_DISCIPLINES + Math.floor(newTotalXP / 500), MAX_CONCURRENT_DISCIPLINES + 3). All 97 tests pass across DebugTab, discipline-math, and store-actions-discipline suites.

Fixed: handleAddXP in DisciplineDebugSection.tsx now updates totalXP and recalculates concurrentLimit alongside disciplines[id].xp. The formula matches processTick: `Math.min(MAX_CONCURRENT_DISCIPLINES + Math.floor(newTotalXP / 500), MAX_CONCURRENT_DISCIPLINES + 3)`. All 97 tests pass across DebugTab, discipline-math, and store-actions-discipline suites.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?