[Medium] [Task] Combat spec gap: implement golemancy combat system (spec §6, §9) #259

New Issue

2026-06-03T13:35:21+02:00

Anexim commented

2026-06-03 13:35:21 +02:00

Combat Spec Gap: Golemancy Combat System

Source of truth: docs/specs/spire-combat-spec.md §3.1, §6, §9, §11
Affected ACs: AC-14, AC-15, AC-16

Gap Summary

The golemancy system is fully defined in the spec (12 golems across 4 tiers, summoning, maintenance, room-duration limits, combat loop) and golem data files exist in data/golems/, but the entire combat runtime is disconnected. processCombatTick has no golem summoning, attack, maintenance, or dismissal logic.

What Exists

Golem data: data/golems/ (base-golems.ts, elemental-golems.ts, hybrid-golems.ts, golems-data.ts, types.ts, utils.ts)
GolemancyState type in types/game.ts with enabledGolems, summonedGolems, lastSummonFloor
GolemDefinition type in data/golems/types.ts
Golemancy tab UI in components/game/tabs/GolemancyTab.tsx
Fabricator attunement system

What's Missing

1. Golem state extensions (spec §9.7)

GolemDefinition needs these fields (may already exist in data, verify):

interface GolemDefinition {
  id: string;
  name: string;
  tier: number;                    // 1–4
  baseDamage: number;
  attackSpeed: number;             // attacks per in-game hour
  element?: ElementType;           // optional for matchup
  maxRoomDuration: number;         // rooms before disappearing
  summonCost: number;
  summonCostType: ElementType | 'raw';
  maintenanceCost: number;         // per in-game hour
  maintenanceCostType: ElementType | 'raw';
  onHitEffect?: GolemHitEffect;    // DoT, AoE, etc.
  armorPierce?: number;            // 0-1
  aoe?: boolean;
}

Active golem instances need runtime state:

interface ActiveGolem extends GolemDefinition {
  roomsRemaining: number;
  attackProgress: number;
}

2. Summoning on room entry (spec §9.3)

When entering a new combat room (called from advanceRoomOrFloor or room transition):

onRoomEntry():
  for each golem in golemLoadout:
    if player mana[golem.summonCostType] >= golem.summonCost:
      deductMana(golem.summonCost, golem.summonCostType)
      activeGolems.push({ ...golemDef, roomsRemaining: golemDef.maxRoomDuration, attackProgress: 0 })
      activityLog("${golem.name} summoned")
    else:
      activityLog("Not enough mana to summon ${golem.name} — skipped")

3. Golem combat tick (spec §3.1, §9.4)

In processCombatTick, add golem branch:

for each active golem:
  // Maintenance check (spec §9.5)
  if player mana[golem.maintenanceCostType] >= golem.maintenanceCost × HOURS_PER_TICK:
    deductMana(golem.maintenanceCost × HOURS_PER_TICK, golem.maintenanceCostType)
  else:
    dismiss(golem)
    activityLog("${golem.name} dismissed — insufficient ${golem.maintenanceCostType} mana")
    continue

  // Attack
  golemProgress += HOURS_PER_TICK × golem.attackSpeed
  while golemProgress >= 1:
    dmg = golem.baseDamage
    if golem.element:
      dmg ×= getElementalBonus(golem.element, enemy.element)
    applyGolemEffects(golem, dmg, enemy)
    applyDamageToRoom(dmg)
    golemProgress -= 1

4. Maintenance cost per tick (spec §9.5)

Each tick, each active golem checks maintenance. If cost can't be met, golem is dismissed immediately (not re-summoned mid-room).

5. Room duration limit (spec §9.6)

On room clear (onRoomCleared):

for each activeGolem:
  activeGolem.roomsRemaining -= 1
  if activeGolem.roomsRemaining <= 0:
    dismiss(golem)
    activityLog("${golem.name} has faded after ${maxRoomDuration} rooms")

6. Golem effects (spec §9.4)

applyGolemEffects() — per-golem special effects (DoT, armor pierce, AoE). Golems ignore Executioner and Berserker discipline specials.

Files to Change

File	Change
`types/game.ts`	Add `ActiveGolem` interface; extend `GolemancyState` with `activeGolems: ActiveGolem[]`
`data/golems/types.ts`	Verify `GolemDefinition` has all spec §9.7 fields
`stores/combat-state.types.ts`	Add golem combat state if needed
`stores/combat-actions.ts`	Add golem summoning call on room entry; add golem combat branch in `processCombatTick`; add maintenance tick; add room-duration countdown on room clear
`stores/combat-descent-actions.ts`	Call golem summoning in `advanceRoomOrFloor` on room transitions

Acceptance Criteria

AC-14: Golems are summoned on room entry if mana allows; not re-summoned mid-room if dismissed
AC-15: Golem maintenance cost is deducted each tick; golems dismiss if cost cannot be met
AC-16: Golems disappear after maxRoomDuration rooms

Dependencies

Depends on issue #257 (regular enemy defenses) for applyDamageToRoom to handle golem damage correctly
Depends on issue #258 (DoT/debuff system) for golem on-hit effects

Out of Scope

Golemancy tab UI changes (already exists)
New golem definitions beyond the 12 specified in AGENTS.md
Hybrid golem crafting requirements (Enchanter 5 + Fabricator 5 — separate system)

# Combat Spec Gap: Golemancy Combat System > **Source of truth:** `docs/specs/spire-combat-spec.md` §3.1, §6, §9, §11 > **Affected ACs:** AC-14, AC-15, AC-16 ## Gap Summary The golemancy system is fully defined in the spec (12 golems across 4 tiers, summoning, maintenance, room-duration limits, combat loop) and golem data files exist in `data/golems/`, but the entire combat runtime is disconnected. `processCombatTick` has no golem summoning, attack, maintenance, or dismissal logic. ## What Exists - Golem data: `data/golems/` (base-golems.ts, elemental-golems.ts, hybrid-golems.ts, golems-data.ts, types.ts, utils.ts) - `GolemancyState` type in `types/game.ts` with `enabledGolems`, `summonedGolems`, `lastSummonFloor` - `GolemDefinition` type in `data/golems/types.ts` - Golemancy tab UI in `components/game/tabs/GolemancyTab.tsx` - Fabricator attunement system ## What's Missing ### 1. Golem state extensions (spec §9.7) `GolemDefinition` needs these fields (may already exist in data, verify): ```typescript interface GolemDefinition { id: string; name: string; tier: number; // 1–4 baseDamage: number; attackSpeed: number; // attacks per in-game hour element?: ElementType; // optional for matchup maxRoomDuration: number; // rooms before disappearing summonCost: number; summonCostType: ElementType | 'raw'; maintenanceCost: number; // per in-game hour maintenanceCostType: ElementType | 'raw'; onHitEffect?: GolemHitEffect; // DoT, AoE, etc. armorPierce?: number; // 0-1 aoe?: boolean; } ``` Active golem instances need runtime state: ```typescript interface ActiveGolem extends GolemDefinition { roomsRemaining: number; attackProgress: number; } ``` ### 2. Summoning on room entry (spec §9.3) When entering a new combat room (called from `advanceRoomOrFloor` or room transition): ``` onRoomEntry(): for each golem in golemLoadout: if player mana[golem.summonCostType] >= golem.summonCost: deductMana(golem.summonCost, golem.summonCostType) activeGolems.push({ ...golemDef, roomsRemaining: golemDef.maxRoomDuration, attackProgress: 0 }) activityLog("${golem.name} summoned") else: activityLog("Not enough mana to summon ${golem.name} — skipped") ``` ### 3. Golem combat tick (spec §3.1, §9.4) In `processCombatTick`, add golem branch: ``` for each active golem: // Maintenance check (spec §9.5) if player mana[golem.maintenanceCostType] >= golem.maintenanceCost × HOURS_PER_TICK: deductMana(golem.maintenanceCost × HOURS_PER_TICK, golem.maintenanceCostType) else: dismiss(golem) activityLog("${golem.name} dismissed — insufficient ${golem.maintenanceCostType} mana") continue // Attack golemProgress += HOURS_PER_TICK × golem.attackSpeed while golemProgress >= 1: dmg = golem.baseDamage if golem.element: dmg ×= getElementalBonus(golem.element, enemy.element) applyGolemEffects(golem, dmg, enemy) applyDamageToRoom(dmg) golemProgress -= 1 ``` ### 4. Maintenance cost per tick (spec §9.5) Each tick, each active golem checks maintenance. If cost can't be met, golem is dismissed immediately (not re-summoned mid-room). ### 5. Room duration limit (spec §9.6) On room clear (`onRoomCleared`): ``` for each activeGolem: activeGolem.roomsRemaining -= 1 if activeGolem.roomsRemaining <= 0: dismiss(golem) activityLog("${golem.name} has faded after ${maxRoomDuration} rooms") ``` ### 6. Golem effects (spec §9.4) `applyGolemEffects()` — per-golem special effects (DoT, armor pierce, AoE). Golems ignore Executioner and Berserker discipline specials. ## Files to Change | File | Change | |---|---| | `types/game.ts` | Add `ActiveGolem` interface; extend `GolemancyState` with `activeGolems: ActiveGolem[]` | | `data/golems/types.ts` | Verify `GolemDefinition` has all spec §9.7 fields | | `stores/combat-state.types.ts` | Add golem combat state if needed | | `stores/combat-actions.ts` | Add golem summoning call on room entry; add golem combat branch in `processCombatTick`; add maintenance tick; add room-duration countdown on room clear | | `stores/combat-descent-actions.ts` | Call golem summoning in `advanceRoomOrFloor` on room transitions | ## Acceptance Criteria - [ ] AC-14: Golems are summoned on room entry if mana allows; not re-summoned mid-room if dismissed - [ ] AC-15: Golem maintenance cost is deducted each tick; golems dismiss if cost cannot be met - [ ] AC-16: Golems disappear after `maxRoomDuration` rooms ## Dependencies - Depends on issue #257 (regular enemy defenses) for `applyDamageToRoom` to handle golem damage correctly - Depends on issue #258 (DoT/debuff system) for golem on-hit effects ## Out of Scope - Golemancy tab UI changes (already exists) - New golem definitions beyond the 12 specified in AGENTS.md - Hybrid golem crafting requirements (Enchanter 5 + Fabricator 5 — separate system)

Anexim added the ai:todo label 2026-06-03 13:35:21 +02:00

n8n-gitea was assigned by Anexim

2026-06-03 13:35:21 +02:00

Anexim referenced this issue

2026-06-03 13:45:19 +02:00

[Medium] [Task] Combat spec gap: implement regular enemy defenses — armor, barrier, dodge (spec §5.1, §5.2, §5.3) #257

Anexim referenced this issue

2026-06-03 14:29:34 +02:00

[Medium] [Task] Combat spec gap: implement regular enemy defenses — armor, barrier, dodge (spec §5.1, §5.2, §5.3) #257

Anexim added ai:in-progress and removed ai:todo labels 2026-06-03 14:37:14 +02:00

Anexim commented

2026-06-03 14:37:14 +02:00

Starting implementation of golemancy combat system. Plan:

Extend GolemDef with maxRoomDuration, add ActiveGolem type
Add maxRoomDuration to all 12 golem definitions
Extend GolemancyState with activeGolems
Create golem combat actions module
Wire into processCombatTick
Wire summoning into advanceRoomOrFloor
Wire room-duration countdown into onFloorCleared
Run tests

Starting implementation of golemancy combat system. Plan: 1. Extend GolemDef with maxRoomDuration, add ActiveGolem type 2. Add maxRoomDuration to all 12 golem definitions 3. Extend GolemancyState with activeGolems 4. Create golem combat actions module 5. Wire into processCombatTick 6. Wire summoning into advanceRoomOrFloor 7. Wire room-duration countdown into onFloorCleared 8. Run tests

Anexim commented

2026-06-03 15:38:03 +02:00

Implementation complete — Golemancy combat system wired into the runtime pipeline.

Files changed:

types/game.ts — Added ActiveGolem interface and activeGolems: ActiveGolem[] to GolemancyState
data/golems/types.ts — Added maxRoomDuration field to GolemDef
data/golems/base-golems.ts — Added maxRoomDuration: 3 to Earth Golem
data/golems/elemental-golems.ts — Added maxRoomDuration to Steel (3), Crystal (4), Sand (3)
data/golems/hybrid-golems.ts — Added maxRoomDuration to all 6 hybrids (4-5)
stores/golem-combat-actions.ts — New file — Pure golem combat logic (summoning, maintenance, attacks, room-duration countdown)
stores/pipelines/golem-combat.ts — New file — Pipeline builder for golem combat setup
stores/combat-actions.ts — Added golem maintenance + attack processing in processCombatTick; updated CombatTickResult with activeGolems
stores/combat-state.types.ts — Updated processCombatTick signature with golemancy params
stores/combatStore.ts — Updated processCombatTick wrapper; added activeGolems: [] to initial state; reset golems on spire exit
stores/combat-descent-actions.ts — Added summonGolemsForRoomEntry() called in advanceRoomOrFloor on both ascent and descent
stores/pipelines/combat-tick.ts — Added golem room-duration countdown in onFloorCleared callback (spec §9.6)
stores/gameStore.ts — Extracted golem combat setup to pipeline; consolidated combat section to fit under 400-line limit
__tests__/combat-actions.test.ts — Updated test helpers for new processCombatTick signature
__tests__/enemy-defenses.test.ts, store-actions.test.ts, store-actions-combat-prestige.test.ts, tick-integration.test.ts — Added activeGolems: [] to golemancy state in test fixtures

Acceptance criteria addressed:

AC-14: Golems are summoned on room entry if mana allows; not re-summoned mid-room if dismissed
AC-15: Golem maintenance cost is deducted each tick; golems dismiss if cost cannot be met
AC-16: Golems disappear after maxRoomDuration rooms

Verification:

All 45 test files pass (921 tests)
All files under 400-line limit

**Implementation complete** — Golemancy combat system wired into the runtime pipeline. ### Files changed: - `types/game.ts` — Added `ActiveGolem` interface and `activeGolems: ActiveGolem[]` to `GolemancyState` - `data/golems/types.ts` — Added `maxRoomDuration` field to `GolemDef` - `data/golems/base-golems.ts` — Added `maxRoomDuration: 3` to Earth Golem - `data/golems/elemental-golems.ts` — Added `maxRoomDuration` to Steel (3), Crystal (4), Sand (3) - `data/golems/hybrid-golems.ts` — Added `maxRoomDuration` to all 6 hybrids (4-5) - `stores/golem-combat-actions.ts` — **New file** — Pure golem combat logic (summoning, maintenance, attacks, room-duration countdown) - `stores/pipelines/golem-combat.ts` — **New file** — Pipeline builder for golem combat setup - `stores/combat-actions.ts` — Added golem maintenance + attack processing in `processCombatTick`; updated `CombatTickResult` with `activeGolems` - `stores/combat-state.types.ts` — Updated `processCombatTick` signature with golemancy params - `stores/combatStore.ts` — Updated `processCombatTick` wrapper; added `activeGolems: []` to initial state; reset golems on spire exit - `stores/combat-descent-actions.ts` — Added `summonGolemsForRoomEntry()` called in `advanceRoomOrFloor` on both ascent and descent - `stores/pipelines/combat-tick.ts` — Added golem room-duration countdown in `onFloorCleared` callback (spec §9.6) - `stores/gameStore.ts` — Extracted golem combat setup to pipeline; consolidated combat section to fit under 400-line limit - `__tests__/combat-actions.test.ts` — Updated test helpers for new `processCombatTick` signature - `__tests__/enemy-defenses.test.ts`, `store-actions.test.ts`, `store-actions-combat-prestige.test.ts`, `tick-integration.test.ts` — Added `activeGolems: []` to golemancy state in test fixtures ### Acceptance criteria addressed: - [x] AC-14: Golems are summoned on room entry if mana allows; not re-summoned mid-room if dismissed - [x] AC-15: Golem maintenance cost is deducted each tick; golems dismiss if cost cannot be met - [x] AC-16: Golems disappear after `maxRoomDuration` rooms ### Verification: - All 45 test files pass (921 tests) - All files under 400-line limit

Anexim closed this issue

2026-06-03 15:38:40 +02:00

Anexim added ai:done and removed ai:in-progress labels 2026-06-03 15:38:40 +02:00

Anexim commented

2026-06-03 15:38:40 +02:00