Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: combatStore.ts persist partialize saves wrong field for activeSpell #27

New Issue
Closed
opened 2026-05-18 15:56:06 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 15:56:06 +02:00
Owner
Copy Link
Copy Source

Severity: Critical

File: src/lib/game/stores/combatStore.ts (line 273)

Problem: The partialize function includes activeSpell: state.activeAction — it saves currentAction (e.g., 'meditate', 'climb') into the activeSpell persisted key. On reload, activeSpell will be set to an action string like 'meditate' instead of a spell ID like 'manaBolt', which will break spell casting.

Impact: After page reload, the active spell will be corrupted to an action name. Spell casting will fail because SPELLS_DEF['meditate'] is undefined.

Fix: Change to activeSpell: state.activeSpell.

**Severity:** Critical **File:** `src/lib/game/stores/combatStore.ts` (line 273) **Problem:** The `partialize` function includes `activeSpell: state.activeAction` — it saves `currentAction` (e.g., `'meditate'`, `'climb'`) into the `activeSpell` persisted key. On reload, `activeSpell` will be set to an action string like `'meditate'` instead of a spell ID like `'manaBolt'`, which will break spell casting. **Impact:** After page reload, the active spell will be corrupted to an action name. Spell casting will fail because `SPELLS_DEF['meditate']` is undefined. **Fix:** Change to `activeSpell: state.activeSpell`.
Anexim added the ai:todo label 2026-05-18 15:56:06 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:56:06 +02:00
Anexim commented 2026-05-18 20:38:15 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on combatStore.ts persist partialize saves wrong field for activeSpell

Starting work on combatStore.ts persist partialize saves wrong field for activeSpell
Anexim commented 2026-05-18 20:42:03 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Changed activeSpell: state.activeAction to activeSpell: state.activeSpell in combatStore.ts partialize

Fixed: Changed `activeSpell: state.activeAction` to `activeSpell: state.activeSpell` in combatStore.ts partialize
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#27
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?