[Medium] [Task] [WIP/Incomplete] Mana conversion spec defines a complete new system but says "Manual conversion removed" — migration needed #279
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: Work in progress / Incomplete feature
Priority: Medium
mana-conversion-spec.md defines a complete unified mana conversion system that replaces the current fragmented approach. Key points:
convertManaaction andprocessConvertActionare removed."convertMana,processConvertAction,craftComposite" from manaStoreBut the spec also says:
convertManaandcraftCompositestore actions are kept as no-ops for save compatibility but have no UI"This is contradictory — it says both "removed" and "kept as no-ops."
The spec defines:
element-distance.ts,conversion-rates.ts,conversion-costs.tscraftCompositeThis is a major system overhaul that affects manaStore, gameStore, prestigeStore, attunements, disciplines, and UI components. The spec is detailed but it's unclear if any of this has been implemented.
Recommendation: Determine the current implementation status of the unified mana conversion system. If not implemented, create a plan for the migration.
ultimate truth: follow the recommendation
RESOLVED — Created new Gitea issue #287. The old
convertMana/craftCompositeactions have been fully removed frommanaStore.ts. The replacement unified passive conversion system frommana-conversion-spec.mdis NOT yet implemented. The game currently has no mana conversion mechanism.✅ RESOLVED — Created new Gitea issue #287. The old convertMana/craftComposite actions have been fully removed from manaStore.ts. The replacement unified passive conversion system from mana-conversion-spec.md is NOT yet implemented.