Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: totalManaGathered incorrectly accumulates spell costs instead of mana gathered #28

New Issue
Closed
opened 2026-05-18 15:56:07 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 15:56:07 +02:00
Owner
Copy Link
Copy Source

Severity: Critical

File: src/lib/game/stores/combat-actions.ts (lines 48, 79)

Problem: totalManaGathered += spellDef.cost.amount is added every time a spell is cast. This is spell cost spent, not mana gathered. This inflates the totalManaGathered stat, which feeds into calcInsight(), making insight gains artificially high proportional to combat casting.

Impact: Players gain more insight than intended based on how much they cast spells, breaking game balance.

Fix: Remove totalManaGathered accumulation from processCombatTick. Mana gathering should only happen in gatherMana and passive regen ticks in the game store.

**Severity:** Critical **File:** `src/lib/game/stores/combat-actions.ts` (lines 48, 79) **Problem:** `totalManaGathered += spellDef.cost.amount` is added every time a spell is cast. This is **spell cost spent**, not mana gathered. This inflates the `totalManaGathered` stat, which feeds into `calcInsight()`, making insight gains artificially high proportional to combat casting. **Impact:** Players gain more insight than intended based on how much they cast spells, breaking game balance. **Fix:** Remove `totalManaGathered` accumulation from `processCombatTick`. Mana gathering should only happen in `gatherMana` and passive regen ticks in the game store.
Anexim added the ai:todo label 2026-05-18 15:56:07 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:56:07 +02:00
Anexim commented 2026-05-18 20:38:15 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on totalManaGathered incorrectly accumulates spell costs

Starting work on totalManaGathered incorrectly accumulates spell costs
Anexim commented 2026-05-18 20:42:03 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Removed totalManaGathered += spellDef.cost.amount from both spell cast loops in combat-actions.ts. Mana gathering should only happen in gatherMana and passive regen.

Fixed: Removed `totalManaGathered += spellDef.cost.amount` from both spell cast loops in combat-actions.ts. Mana gathering should only happen in gatherMana and passive regen.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#28
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?