Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[High] [Bug] [Spec-Inconsistency] pactBinding upgrade referenced in code but not defined in PRESTIGE_DEF constants #281

New Issue
Closed
opened 2026-06-05 02:14:32 +02:00 by Anexim · 3 comments
Anexim commented 2026-06-05 02:14:32 +02:00
Owner
Copy Link
Copy Source

Type: Spec / Code inconsistency
Priority: High

invoker-spec.md §10 Known Code Issues:

Issue Description
pactBinding upgrade Referenced in prestigeStore.doPrestige but not defined in PRESTIGE_DEF constants
UI vs store mismatch UI displays prestigeUpgrades.pactCapacity but store logic checks pactBinding
pactInterferenceMitigation Used in pact-utils.ts but no prestige upgrade defines it

pact-system-spec.md §4.2 also notes:

Note: The pactBinding upgrade is referenced in the store logic but is not defined in PRESTIGE_DEF constants. This is a known gap — the upgrade exists in code but has no definition, cost, or max level.

This means:

  1. The pactBinding upgrade is referenced in the prestige store logic but has no definition
  2. The UI shows pactCapacity but the store checks pactBinding — a naming mismatch
  3. pactInterferenceMitigation is used in pact calculations but has no prestige upgrade

Recommendation: Define the missing pactBinding upgrade in PRESTIGE_DEF constants with proper cost, max level, and description. Fix the naming mismatch between UI and store. Define pactInterferenceMitigation as a prestige upgrade.

**Type:** Spec / Code inconsistency **Priority:** High **invoker-spec.md §10** Known Code Issues: > | Issue | Description | > |---|---| > | `pactBinding` upgrade | Referenced in `prestigeStore.doPrestige` but **not defined** in `PRESTIGE_DEF` constants | > | UI vs store mismatch | UI displays `prestigeUpgrades.pactCapacity` but store logic checks `pactBinding` | > | `pactInterferenceMitigation` | Used in `pact-utils.ts` but no prestige upgrade defines it | **pact-system-spec.md §4.2** also notes: > **Note:** The `pactBinding` upgrade is referenced in the store logic but is **not defined** in `PRESTIGE_DEF` constants. This is a known gap — the upgrade exists in code but has no definition, cost, or max level. This means: 1. The `pactBinding` upgrade is referenced in the prestige store logic but has no definition 2. The UI shows `pactCapacity` but the store checks `pactBinding` — a naming mismatch 3. `pactInterferenceMitigation` is used in pact calculations but has no prestige upgrade **Recommendation:** Define the missing `pactBinding` upgrade in `PRESTIGE_DEF` constants with proper cost, max level, and description. Fix the naming mismatch between UI and store. Define `pactInterferenceMitigation` as a prestige upgrade.
Anexim added the ai:todo label 2026-06-05 02:14:32 +02:00
n8n-gitea was assigned by Anexim 2026-06-05 02:14:32 +02:00
Anexim commented 2026-06-05 13:15:48 +02:00
Author
Owner
Copy Link
Copy Source

ultimate truth: follow the recommendation

ultimate truth: follow the recommendation
Anexim commented 2026-06-05 13:54:33 +02:00
Author
Owner
Copy Link
Copy Source

RESOLVED — Added missing pactBinding and pactInterferenceMitigation prestige upgrades to PRESTIGE_DEF in prestige.ts. Updated useGameDerived.ts to pass pactInterferenceMitigation from prestige store to pact multiplier functions. The naming mismatch between UI (pactCapacity) and store (pactBinding) is now resolved — pactBinding is the canonical ID.

**RESOLVED** — Added missing `pactBinding` and `pactInterferenceMitigation` prestige upgrades to `PRESTIGE_DEF` in `prestige.ts`. Updated `useGameDerived.ts` to pass `pactInterferenceMitigation` from prestige store to pact multiplier functions. The naming mismatch between UI (`pactCapacity`) and store (`pactBinding`) is now resolved — `pactBinding` is the canonical ID.
Anexim added ai:done and removed ai:todo labels 2026-06-05 14:30:22 +02:00
Anexim commented 2026-06-05 14:30:22 +02:00
Author
Owner
Copy Link
Copy Source

✅ RESOLVED — Added missing pactBinding and pactInterferenceMitigation prestige upgrades to PRESTIGE_DEF in prestige.ts. Updated useGameDerived.ts to pass pactInterferenceMitigation from prestige store to pact multiplier functions.

✅ RESOLVED — Added missing pactBinding and pactInterferenceMitigation prestige upgrades to PRESTIGE_DEF in prestige.ts. Updated useGameDerived.ts to pass pactInterferenceMitigation from prestige store to pact multiplier functions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?