[Medium] [Bug] Enchanting: spell_iceShard defined twice with different costs (75 vs 95) #303

New Issue

2026-06-07T17:42:18+02:00

Anexim commented

2026-06-07 17:42:18 +02:00

Spec: docs/specs/attunements/enchanter/systems/enchanting-spec.md §7.1
Severity: Wrong value

Problem: spell_iceShard is defined in both:

src/lib/game/data/enchantments/spell-effects/basic-spells.ts:53-60 with baseCapacityCost: 75
src/lib/game/data/enchantments/spell-effects/frost-spells.ts:23-30 with baseCapacityCost: 95

Since both are merged into the same ENCHANTMENT_EFFECTS record via spread in spell-effects/index.ts:28-29, the frost-spells version (cost 95) overwrites the basic-spells version (cost 75). The spec lists this ID twice with different costs, which is also a spec ambiguity.

File: src/lib/game/data/enchantments/spell-effects/index.ts:28-29

**Spec:** docs/specs/attunements/enchanter/systems/enchanting-spec.md §7.1 **Severity:** Wrong value **Problem:** `spell_iceShard` is defined in both: - `src/lib/game/data/enchantments/spell-effects/basic-spells.ts:53-60` with `baseCapacityCost: 75` - `src/lib/game/data/enchantments/spell-effects/frost-spells.ts:23-30` with `baseCapacityCost: 95` Since both are merged into the same `ENCHANTMENT_EFFECTS` record via spread in `spell-effects/index.ts:28-29`, the frost-spells version (cost 95) overwrites the basic-spells version (cost 75). The spec lists this ID twice with different costs, which is also a spec ambiguity. **File:** `src/lib/game/data/enchantments/spell-effects/index.ts:28-29`

Anexim added the ai:todo label 2026-06-07 17:42:18 +02:00

n8n-gitea was assigned by Anexim

2026-06-07 17:42:18 +02:00

Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 14:33:33 +02:00

Anexim commented

2026-06-08 14:33:33 +02:00

Starting work on spell_iceShard duplicate definition bug. Will investigate both files and the spec to determine the correct cost, then remove the duplicate.

Anexim closed this issue

2026-06-08 14:36:54 +02:00

Anexim added ai:done and removed ai:in-progress labels 2026-06-08 14:36:54 +02:00

Anexim commented

2026-06-08 14:36:54 +02:00

Fix applied and pushed. Removed the duplicate spell_iceShard entry from basic-spells.ts (cost 75, water damage). The canonical version in frost-spells.ts (cost 95, frost damage) is now the sole definition, which is the intended behavior — the frost version overwrites the basic one via spread order in spell-effects/index.ts.

Root cause: Both basic-spells.ts:53-60 and frost-spells.ts:23-30 defined spell_iceShard with the same ID. Since frost-spells is spread after basic-spells in the index, the cost was silently 95 instead of 75.

Fix: Removed the basic-spells duplicate (10 lines). File size: 163 lines (under 400 limit).

Tests: 1069 passed (58 files), all pre-commit checks pass.

**Fix applied and pushed.** Removed the duplicate `spell_iceShard` entry from `basic-spells.ts` (cost 75, water damage). The canonical version in `frost-spells.ts` (cost 95, frost damage) is now the sole definition, which is the intended behavior — the frost version overwrites the basic one via spread order in `spell-effects/index.ts`. **Root cause:** Both `basic-spells.ts:53-60` and `frost-spells.ts:23-30` defined `spell_iceShard` with the same ID. Since `frost-spells` is spread after `basic-spells` in the index, the cost was silently 95 instead of 75. **Fix:** Removed the basic-spells duplicate (10 lines). File size: 163 lines (under 400 limit). **Tests:** 1069 passed (58 files), all pre-commit checks pass.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#303