Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Pact System: signedPactDetails never populated by any production code #308

New Issue
Closed
opened 2026-06-07 17:42:20 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-07 17:42:20 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/invoker/systems/pact-system-spec.md §5.1
Severity: Medium

Problem: The signedPactDetails state field exists in prestigeStore.ts:41 and is persisted, but no production code writes to it. Both completePactRitual in prestigeStore.ts:113-143 and processPactRitual in pact-ritual.ts:30-52 never set it. Only debugSetPactDetails can write to it. Historical pact tracking is non-functional.

Files:

  • src/lib/game/stores/prestigeStore.ts:113-143
  • src/lib/game/stores/pipelines/pact-ritual.ts:30-52
**Spec:** docs/specs/attunements/invoker/systems/pact-system-spec.md §5.1 **Severity:** Medium **Problem:** The `signedPactDetails` state field exists in `prestigeStore.ts:41` and is persisted, but **no production code writes to it**. Both `completePactRitual` in `prestigeStore.ts:113-143` and `processPactRitual` in `pact-ritual.ts:30-52` never set it. Only `debugSetPactDetails` can write to it. Historical pact tracking is non-functional. **Files:** - `src/lib/game/stores/prestigeStore.ts:113-143` - `src/lib/game/stores/pipelines/pact-ritual.ts:30-52`
Anexim added the ai:todo label 2026-06-07 17:42:20 +02:00
n8n-gitea was assigned by Anexim 2026-06-07 17:42:20 +02:00
Anexim added ai:done and removed ai:todo labels 2026-06-08 14:28:42 +02:00
Anexim commented 2026-06-08 14:28:43 +02:00
Author
Owner
Copy Link
Copy Source

Fixed. The root cause was that processPactRitual in pact-ritual.ts (the actual production code path for pact completion) never included signedPactDetails in its writes. Fixed by:

  1. Added signedPactDetails to PactRitualResult.writes interface
  2. Added signedPactDetails, currentDay, currentHour parameters to processPactRitual
  3. When completing a pact, the writes now include the new pact detail entry with floor, guardianId, signedAt time, and empty skillLevels
  4. Updated gameStore.ts call site to pass ctx.prestige.signedPactDetails and day, hour
  5. Also fixed completePactRitual in prestigeStore.ts for completeness (was dead code, now correct if called in future)
Fixed. The root cause was that `processPactRitual` in `pact-ritual.ts` (the actual production code path for pact completion) never included `signedPactDetails` in its writes. Fixed by: 1. Added `signedPactDetails` to `PactRitualResult.writes` interface 2. Added `signedPactDetails`, `currentDay`, `currentHour` parameters to `processPactRitual` 3. When completing a pact, the writes now include the new pact detail entry with floor, guardianId, signedAt time, and empty skillLevels 4. Updated `gameStore.ts` call site to pass `ctx.prestige.signedPactDetails` and `day, hour` 5. Also fixed `completePactRitual` in `prestigeStore.ts` for completeness (was dead code, now correct if called in future)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#308
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?