Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Remove duplicate discipline definition files (dead code) #31

New Issue
Closed
opened 2026-05-18 15:57:51 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-18 15:57:51 +02:00
Owner
Copy Link
Copy Source

Severity: Major

Files:

  • src/lib/game/data/disciplines/base-disciplines.ts
  • src/lib/game/data/disciplines/enchanter-disciplines.ts
  • src/lib/game/data/disciplines/fabricator-disciplines.ts
  • src/lib/game/data/disciplines/invoker-disciplines.ts

Problem: These files are legacy/abandoned versions with entirely different data shapes from the canonical files (base.ts, enchanter.ts, fabricator.ts, invoker.ts). They define:

  • Duplicate exported names (e.g., baseDisciplines, enchanterDisciplines) that conflict with the proper versions
  • Local duplicate DisciplinesAttunementType enums and DisciplineDefinition types with incompatible shapes
  • fabricator-disciplines.ts and invoker-disciplines.ts use export default but are never imported

The index.ts barrel imports from the correct files, so these dead files are not used. However, they create confusion and could be accidentally imported.

Impact: Maintenance burden, potential for accidental imports, confusing duplicate type definitions.

Fix: Delete all four *-disciplines.ts files.

**Severity:** Major **Files:** - `src/lib/game/data/disciplines/base-disciplines.ts` - `src/lib/game/data/disciplines/enchanter-disciplines.ts` - `src/lib/game/data/disciplines/fabricator-disciplines.ts` - `src/lib/game/data/disciplines/invoker-disciplines.ts` **Problem:** These files are legacy/abandoned versions with entirely different data shapes from the canonical files (`base.ts`, `enchanter.ts`, `fabricator.ts`, `invoker.ts`). They define: - Duplicate exported names (e.g., `baseDisciplines`, `enchanterDisciplines`) that conflict with the proper versions - Local duplicate `DisciplinesAttunementType` enums and `DisciplineDefinition` types with incompatible shapes - `fabricator-disciplines.ts` and `invoker-disciplines.ts` use `export default` but are never imported The `index.ts` barrel imports from the correct files, so these dead files are not used. However, they create confusion and could be accidentally imported. **Impact:** Maintenance burden, potential for accidental imports, confusing duplicate type definitions. **Fix:** Delete all four `*-disciplines.ts` files.
Anexim added the ai:todo label 2026-05-18 15:57:51 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:57:51 +02:00
Anexim commented 2026-05-18 20:58:23 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Deleted 4 duplicate discipline definition files (base-disciplines.ts, enchanter-disciplines.ts, fabricator-disciplines.ts, invoker-disciplines.ts) that had incompatible types and conflicting exports.

Fixed: Deleted 4 duplicate discipline definition files (base-disciplines.ts, enchanter-disciplines.ts, fabricator-disciplines.ts, invoker-disciplines.ts) that had incompatible types and conflicting exports.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#31
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?