Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Golemancy: Crystal-Steel Hybrid frame over-gated (requires Enchanter 5) #314

New Issue
Closed
opened 2026-06-07 17:43:56 +02:00 by Anexim · 3 comments
Anexim commented 2026-06-07 17:43:56 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/fabricator/systems/golemancy-spec.md §5.3, §16.3
Severity: Wrong value

Problem: src/lib/game/data/golems/frames.ts:139-143 — Crystal-Steel Hybrid frame requires dual_attunement (Fabricator 5 + Enchanter 5). The spec says only Fabricator 5 is needed. This over-gates the frame, making it harder to unlock than intended.

File: src/lib/game/data/golems/frames.ts:139-143

**Spec:** docs/specs/attunements/fabricator/systems/golemancy-spec.md §5.3, §16.3 **Severity:** Wrong value **Problem:** `src/lib/game/data/golems/frames.ts:139-143` — Crystal-Steel Hybrid frame requires `dual_attunement` (Fabricator 5 + Enchanter 5). The spec says only Fabricator 5 is needed. This over-gates the frame, making it harder to unlock than intended. **File:** `src/lib/game/data/golems/frames.ts:139-143`
Anexim added the ai:todo label 2026-06-07 17:43:56 +02:00
n8n-gitea was assigned by Anexim 2026-06-07 17:43:56 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 14:12:05 +02:00
Anexim commented 2026-06-08 14:12:05 +02:00
Author
Owner
Copy Link
Copy Source

Starting investigation. Reading frames.ts and the golemancy spec to understand the over-gating issue.

Starting investigation. Reading frames.ts and the golemancy spec to understand the over-gating issue.
Anexim commented 2026-06-08 14:15:18 +02:00
Author
Owner
Copy Link
Copy Source

Fix Summary:

Root Cause: frames.ts:139-143 — Crystal-Steel Hybrid frame had unlockRequirement with type: 'dual_attunement' requiring Fabricator 5 + Enchanter 5. The spec (§5.3 and §16.3) states only Fabricator 5 is needed.

Changes:

  1. src/lib/game/data/golems/frames.ts — Changed unlockRequirement from dual_attunement (fabricator 5 + enchanter 5) to attunement_level (fabricator 5 only)
  2. src/lib/game/data/golems/golemancy-data.test.ts — Updated the test from asserting dual_attunement to asserting attunement_level, now checks only fabricator level

Verification: All 1069 tests pass across 58 test files. The regression test (crystalSteelHybrid frame requires Fabricator 5 only) passes on the fixed code.

**Fix Summary:** **Root Cause:** `frames.ts:139-143` — Crystal-Steel Hybrid frame had `unlockRequirement` with `type: 'dual_attunement'` requiring Fabricator 5 + Enchanter 5. The spec (§5.3 and §16.3) states only Fabricator 5 is needed. **Changes:** 1. `src/lib/game/data/golems/frames.ts` — Changed `unlockRequirement` from `dual_attunement` (fabricator 5 + enchanter 5) to `attunement_level` (fabricator 5 only) 2. `src/lib/game/data/golems/golemancy-data.test.ts` — Updated the test from asserting `dual_attunement` to asserting `attunement_level`, now checks only fabricator level **Verification:** All 1069 tests pass across 58 test files. The regression test (`crystalSteelHybrid frame requires Fabricator 5 only`) passes on the fixed code.
Anexim added ai:done and removed ai:in-progress labels 2026-06-08 14:15:18 +02:00
Anexim commented 2026-06-08 14:15:18 +02:00
Author
Owner
Copy Link
Copy Source

Fix completed and pushed. Crystal-Steel Hybrid frame now correctly requires only Fabricator 5 per spec §5.3 / §16.3.

Fix completed and pushed. Crystal-Steel Hybrid frame now correctly requires only Fabricator 5 per spec §5.3 / §16.3.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?