Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Fabricator: Perk ID mismatches between spec and code #318

New Issue
Closed
opened 2026-06-07 17:43:57 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-07 17:43:57 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/fabricator/fabricator-spec.md §6
Severity: Wrong value

Problem: Multiple perk IDs in src/lib/game/data/disciplines/fabricator.ts don't match the spec:

  • fabricator-earth vs fabricator-earth-recipes (and metal, sand, crystal)
  • wizard-oak vs wizard-oak-staff
  • wizard-arcanist-gear vs wizard-arcanist-set
  • physical-battle-gear vs physical-battle-set

Any code referencing these IDs by spec name would fail to find them.

File: src/lib/game/data/disciplines/fabricator.ts (multiple lines)

**Spec:** docs/specs/attunements/fabricator/fabricator-spec.md §6 **Severity:** Wrong value **Problem:** Multiple perk IDs in `src/lib/game/data/disciplines/fabricator.ts` don't match the spec: - `fabricator-earth` vs `fabricator-earth-recipes` (and metal, sand, crystal) - `wizard-oak` vs `wizard-oak-staff` - `wizard-arcanist-gear` vs `wizard-arcanist-set` - `physical-battle-gear` vs `physical-battle-set` Any code referencing these IDs by spec name would fail to find them. **File:** `src/lib/game/data/disciplines/fabricator.ts` (multiple lines)
Anexim added the ai:todo label 2026-06-07 17:43:57 +02:00
n8n-gitea was assigned by Anexim 2026-06-07 17:43:57 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 12:54:36 +02:00
Anexim added ai:done and removed ai:in-progress labels 2026-06-08 12:56:31 +02:00
Anexim commented 2026-06-08 12:56:31 +02:00
Author
Owner
Copy Link
Copy Source

Fixed all 7 perk ID mismatches in fabricator.ts to align with spec §6:

  • fabricator-earth-recipes → fabricator-earth
  • fabricator-metal-recipes → fabricator-metal
  • fabricator-sand-recipes → fabricator-sand
  • fabricator-crystal-recipes → fabricator-crystal
  • wizard-oak-staff → wizard-oak
  • wizard-arcanist-set → wizard-arcanist-gear
  • physical-battle-set → physical-battle-gear

All 1060 tests pass. No other code referenced these IDs (isolated change).

Fixed all 7 perk ID mismatches in fabricator.ts to align with spec §6: - `fabricator-earth-recipes` → `fabricator-earth` - `fabricator-metal-recipes` → `fabricator-metal` - `fabricator-sand-recipes` → `fabricator-sand` - `fabricator-crystal-recipes` → `fabricator-crystal` - `wizard-oak-staff` → `wizard-oak` - `wizard-arcanist-set` → `wizard-arcanist-gear` - `physical-battle-set` → `physical-battle-gear` All 1060 tests pass. No other code referenced these IDs (isolated change).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?