Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Remove duplicate LootInventoryDisplay component #32

New Issue
Closed
opened 2026-05-18 15:57:51 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-18 15:57:51 +02:00
Owner
Copy Link
Copy Source

Severity: Major

Files:

  • src/components/game/LootInventory/LootInventoryDisplay.tsx (310 lines)
  • src/components/game/LootInventory/index.tsx (318 lines)

Problem: Both files export a LootInventoryDisplay component with nearly identical functionality but slightly different implementations. The index.tsx version has type annotations on callbacks while LootInventoryDisplay.tsx doesn't. Having both creates maintenance burden and confusion about which is canonical.

Impact: Duplicate code, maintenance burden, potential for inconsistent behavior.

Fix: Consolidate into a single file. Delete LootInventoryDisplay.tsx and keep index.tsx as the canonical version (or vice versa). Update all imports accordingly.

**Severity:** Major **Files:** - `src/components/game/LootInventory/LootInventoryDisplay.tsx` (310 lines) - `src/components/game/LootInventory/index.tsx` (318 lines) **Problem:** Both files export a `LootInventoryDisplay` component with nearly identical functionality but slightly different implementations. The `index.tsx` version has type annotations on callbacks while `LootInventoryDisplay.tsx` doesn't. Having both creates maintenance burden and confusion about which is canonical. **Impact:** Duplicate code, maintenance burden, potential for inconsistent behavior. **Fix:** Consolidate into a single file. Delete `LootInventoryDisplay.tsx` and keep `index.tsx` as the canonical version (or vice versa). Update all imports accordingly.
Anexim added the ai:todo label 2026-05-18 15:57:51 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:57:51 +02:00
Anexim commented 2026-05-18 20:58:23 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Deleted duplicate LootInventoryDisplay.tsx (kept index.tsx as canonical). Both were orphaned anyway.

Fixed: Deleted duplicate LootInventoryDisplay.tsx (kept index.tsx as canonical). Both were orphaned anyway.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?