[High] [Task] Remove the Spells tab #320

Closed
opened 2026-06-08 15:47:55 +02:00 by Anexim · 2 comments
Owner

Problem

The Spells tab (SpellsTab.tsx) is the default tab shown to new players but is essentially useless:

  • It's a read-only list of spells with no way to learn or cast from it
  • Spells are learned through the enchanting system (enchant onto a caster, equip it)
  • The learned/activeSpell state exists but there's no in-game mechanic to learn new spells from this tab
  • Having it as the default tab (useState('spells') in page.tsx) confuses new players

Files

  • src/components/game/tabs/SpellsTab.tsx — the tab component
  • src/components/game/tabs/index.ts — barrel export
  • src/app/page.tsx — tab trigger, TabsContent, lazy import, and default state

Plan

  1. Remove the Spells tab trigger from TabTriggers() in page.tsx
  2. Remove the TabsContent value="spells" block in page.tsx
  3. Remove the lazy import of SpellsTab in page.tsx
  4. Remove the re-export from tabs/index.ts
  5. Delete src/components/game/tabs/SpellsTab.tsx
  6. Change the default activeTab state from 'spells' to 'disciplines' (or another useful tab)

Notes

  • The spell data (SPELLS_DEF, spells store state) should be kept — spells still exist as enchantments
  • Only the UI tab is being removed
## Problem The Spells tab (`SpellsTab.tsx`) is the default tab shown to new players but is essentially useless: - It's a read-only list of spells with no way to learn or cast from it - Spells are learned through the enchanting system (enchant onto a caster, equip it) - The `learned`/`activeSpell` state exists but there's no in-game mechanic to learn new spells from this tab - Having it as the default tab (`useState('spells')` in page.tsx) confuses new players ## Files - `src/components/game/tabs/SpellsTab.tsx` — the tab component - `src/components/game/tabs/index.ts` — barrel export - `src/app/page.tsx` — tab trigger, TabsContent, lazy import, and default state ## Plan 1. Remove the Spells tab trigger from `TabTriggers()` in `page.tsx` 2. Remove the `TabsContent value="spells"` block in `page.tsx` 3. Remove the lazy import of `SpellsTab` in `page.tsx` 4. Remove the re-export from `tabs/index.ts` 5. Delete `src/components/game/tabs/SpellsTab.tsx` 6. Change the default `activeTab` state from `'spells'` to `'disciplines'` (or another useful tab) ## Notes - The spell data (`SPELLS_DEF`, `spells` store state) should be kept — spells still exist as enchantments - Only the UI tab is being removed
Anexim added the ai:todo label 2026-06-08 15:47:55 +02:00
n8n-gitea was assigned by Anexim 2026-06-08 15:47:55 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 15:59:29 +02:00
Author
Owner

Starting work on removing the Spells tab. Will follow the plan: remove tab trigger, TabsContent, lazy import, barrel re-export, delete SpellsTab.tsx, and change default tab.

Starting work on removing the Spells tab. Will follow the plan: remove tab trigger, TabsContent, lazy import, barrel re-export, delete SpellsTab.tsx, and change default tab.
Anexim added ai:done and removed ai:in-progress labels 2026-06-08 16:03:26 +02:00
Author
Owner

Spells tab removed successfully.

Changes made:

  • Removed Spells tab trigger from TabTriggers in page.tsx
  • Removed TabsContent value="spells" block in page.tsx
  • Removed lazy import of SpellsTab in page.tsx
  • Changed default activeTab from 'spells' to 'disciplines'
  • Removed SpellsTab re-export from tabs/index.ts
  • Removed SpellsTab re-export from game/index.ts
  • Deleted src/components/game/tabs/SpellsTab.tsx

Spell data (SPELLS_DEF, spells store state) preserved — spells still exist as enchantments.

All 58 test files (1069 tests) passed. Pre-commit checks passed. Committed and pushed.

✅ Spells tab removed successfully. Changes made: - Removed Spells tab trigger from TabTriggers in page.tsx - Removed TabsContent value="spells" block in page.tsx - Removed lazy import of SpellsTab in page.tsx - Changed default activeTab from 'spells' to 'disciplines' - Removed SpellsTab re-export from tabs/index.ts - Removed SpellsTab re-export from game/index.ts - Deleted src/components/game/tabs/SpellsTab.tsx Spell data (SPELLS_DEF, spells store state) preserved — spells still exist as enchantments. All 58 test files (1069 tests) passed. Pre-commit checks passed. Committed and pushed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#320