Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Fabricator golem-2 capped perk interval is 250 instead of 500 — capacity unlocks too early #328

New Issue
Closed
opened 2026-06-08 16:02:45 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-08 16:02:45 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/fabricator/fabricator-spec.md

Discrepancy found:

D1 [MEDIUM] — Golem Crafting golem-2 capped perk interval is 250 instead of 500

  • File: src/lib/game/data/disciplines/fabricator.ts
  • Spec says: "interval 500 XP, max 2 tiers" (threshold 500, interval 500)
  • Code has: threshold: 500, value: 250
  • Impact: With threshold=500 and value=250, first tier unlocks at XP 500, second at XP 750. With spec's interval of 500, tier 2 would require XP 1000. The code grants the +2 capacity 250 XP earlier than the spec intends.
  • Fix: Change value: 250 to value: 500 on the golem-2 perk

D2 [LOW] — golem-1 description wording mismatch

  • Spec: "Unlock golem summoning"
  • Code: "Unlock golem design ability"
  • Fix: Update description to match spec

All other fields verified as 100% match:

  • Attunement definition (id, slot, icon, color, primaryMana, regen, conversionRate, capabilities, skillCategories) ✅
  • All 5 disciplines present with correct fields ✅
  • All perk thresholds and unlock targets ✅
  • Dependency chains ✅
  • Golem slot formula ✅
**Spec:** `docs/specs/attunements/fabricator/fabricator-spec.md` **Discrepancy found:** ### D1 [MEDIUM] — Golem Crafting `golem-2` capped perk interval is 250 instead of 500 - **File:** `src/lib/game/data/disciplines/fabricator.ts` - **Spec says:** "interval 500 XP, max 2 tiers" (threshold 500, interval 500) - **Code has:** `threshold: 500, value: 250` - **Impact:** With `threshold=500` and `value=250`, first tier unlocks at XP 500, second at XP 750. With spec's interval of 500, tier 2 would require XP 1000. The code grants the +2 capacity **250 XP earlier** than the spec intends. - **Fix:** Change `value: 250` to `value: 500` on the `golem-2` perk ### D2 [LOW] — `golem-1` description wording mismatch - **Spec:** "Unlock golem summoning" - **Code:** "Unlock golem design ability" - **Fix:** Update description to match spec **All other fields verified as 100% match:** - Attunement definition (id, slot, icon, color, primaryMana, regen, conversionRate, capabilities, skillCategories) ✅ - All 5 disciplines present with correct fields ✅ - All perk thresholds and unlock targets ✅ - Dependency chains ✅ - Golem slot formula ✅
Anexim added the ai:todo label 2026-06-08 16:02:45 +02:00
n8n-gitea was assigned by Anexim 2026-06-08 16:02:45 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-09 11:31:10 +02:00
Anexim added ai:done and removed ai:in-progress labels 2026-06-09 11:31:45 +02:00
Anexim commented 2026-06-09 11:31:45 +02:00
Author
Owner
Copy Link
Copy Source

Fixed both discrepancies:

  • D1: Changed golem-2 capped perk value from 250 to 500 (interval now matches spec: every 500 XP)
  • D2: Updated golem-1 description from "Unlock golem design ability" to "Unlock golem summoning"
Fixed both discrepancies: - D1: Changed `golem-2` capped perk `value` from 250 to 500 (interval now matches spec: every 500 XP) - D2: Updated `golem-1` description from "Unlock golem design ability" to "Unlock golem summoning"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?