Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[High] [Bug] PactCost and signingCost mismatch for procedural guardians (Tiers 4-8) #361

New Issue
Closed
opened 2026-06-10 19:27:21 +02:00 by Anexim · 2 comments
Anexim commented 2026-06-10 19:27:21 +02:00
Owner
Copy Link
Copy Source

Severity: High
File: src/lib/game/data/guardian-encounters.ts (lines 128, 175, 213, 253, 294) and src/lib/game/data/guardian-data.ts (line 24)

Description:
The static pactCost helper computes:

hpVal * 0.3 + power * 5 + hpVal * armor * 0.5 + shield * 2 + hpVal * barrier * 0.3

But all 5 procedural guardian generators (Tiers 4-8) use a reduced formula:

hpVal * 0.3 + hpVal * armor * 0.5

This is missing power * 5, shield * 2, and hpVal * barrier * 0.3. Additionally, signingCost.mana uses a different formula than pactCost (e.g., hpVal * 0.35 for Tier 5), meaning the displayed pactCost differs from what the player actually pays.

Impact: The signingCost is what prestigeStore actually charges, so pactCost and signingCost.mana diverge. In Tiers 5-8, signingCost.mana is consistently higher than pactCost, meaning players pay more than the displayed cost.

Fix needed: Align the pactCost formula in procedural generators with the static helper, and ensure signingCost.mana matches pactCost.

**Severity:** High **File:** `src/lib/game/data/guardian-encounters.ts` (lines 128, 175, 213, 253, 294) and `src/lib/game/data/guardian-data.ts` (line 24) **Description:** The static `pactCost` helper computes: ``` hpVal * 0.3 + power * 5 + hpVal * armor * 0.5 + shield * 2 + hpVal * barrier * 0.3 ``` But all 5 procedural guardian generators (Tiers 4-8) use a reduced formula: ``` hpVal * 0.3 + hpVal * armor * 0.5 ``` This is missing `power * 5`, `shield * 2`, and `hpVal * barrier * 0.3`. Additionally, `signingCost.mana` uses a different formula than `pactCost` (e.g., `hpVal * 0.35` for Tier 5), meaning the displayed `pactCost` differs from what the player actually pays. **Impact:** The `signingCost` is what `prestigeStore` actually charges, so `pactCost` and `signingCost.mana` diverge. In Tiers 5-8, `signingCost.mana` is consistently higher than `pactCost`, meaning players pay more than the displayed cost. **Fix needed:** Align the `pactCost` formula in procedural generators with the static helper, and ensure `signingCost.mana` matches `pactCost`.
Anexim added the ai:todo label 2026-06-10 19:27:21 +02:00
n8n-gitea was assigned by Anexim 2026-06-10 19:27:21 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-11 09:03:53 +02:00
Anexim commented 2026-06-11 09:03:53 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on fixing the PactCost/signingCost mismatch for procedural guardians (Tiers 4-8). Investigating guardian data and pact cost calculations.

Starting work on fixing the PactCost/signingCost mismatch for procedural guardians (Tiers 4-8). Investigating guardian data and pact cost calculations.
Anexim added ai:done and removed ai:in-progress labels 2026-06-11 09:06:19 +02:00
Anexim commented 2026-06-11 09:06:19 +02:00
Author
Owner
Copy Link
Copy Source

Fixed. Aligned signingCost.mana with pactCost for all procedural guardian tiers (4-8). The signingCost.mana was missing the armor component (hpVal * armor * 0.5) and in Tier 5 had a different base rate. Now signingCost.mana === pactCost for all procedural guardians. All 1158 tests pass.

Fixed. Aligned signingCost.mana with pactCost for all procedural guardian tiers (4-8). The signingCost.mana was missing the armor component (hpVal * armor * 0.5) and in Tier 5 had a different base rate. Now signingCost.mana === pactCost for all procedural guardians. All 1158 tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?