Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] UI reads crafting data from wrong store — equipment effects always empty #364

New Issue
Closed
opened 2026-06-10 19:28:49 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-10 19:28:49 +02:00
Owner
Copy Link
Copy Source

Severity: Medium
File: src/lib/game/hooks/useGameDerived.ts (lines 143-144)

Description:
useGameStore((s) => s.crafting.equipmentInstances) and useGameStore((s) => s.crafting.equippedInstances) are used to read crafting data. But useGameStore is the game coordinator store, which only persists day, hour, incursionStrength, containmentWards, initialized. The crafting field does not exist on useGameStore — it's on useCraftingStore.

This will always return undefined, meaning computeEquipmentEffects receives empty objects, and equipment-based bonuses are always 0 in the UI.

Impact: UI never shows equipment-based stat bonuses (crit chance, attack speed, etc.). Players can't see accurate combat stats.

Fix needed: Change useGameStore to useCraftingStore for reading equipmentInstances and equippedInstances.

**Severity:** Medium **File:** `src/lib/game/hooks/useGameDerived.ts` (lines 143-144) **Description:** `useGameStore((s) => s.crafting.equipmentInstances)` and `useGameStore((s) => s.crafting.equippedInstances)` are used to read crafting data. But `useGameStore` is the **game coordinator store**, which only persists `day, hour, incursionStrength, containmentWards, initialized`. The `crafting` field does not exist on `useGameStore` — it's on `useCraftingStore`. This will always return `undefined`, meaning `computeEquipmentEffects` receives empty objects, and equipment-based bonuses are always 0 in the UI. **Impact:** UI never shows equipment-based stat bonuses (crit chance, attack speed, etc.). Players can't see accurate combat stats. **Fix needed:** Change `useGameStore` to `useCraftingStore` for reading `equipmentInstances` and `equippedInstances`.
Anexim added the ai:todo label 2026-06-10 19:28:49 +02:00
n8n-gitea was assigned by Anexim 2026-06-10 19:28:49 +02:00
Anexim added ai:done and removed ai:todo labels 2026-06-11 11:38:06 +02:00
Anexim commented 2026-06-11 11:38:06 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Changed useGameDerived.ts to read equipmentInstances and equippedInstances from useCraftingStore instead of useGameStore (which doesn't have crafting data).

Fixed: Changed useGameDerived.ts to read equipmentInstances and equippedInstances from useCraftingStore instead of useGameStore (which doesn't have crafting data).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?