Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Low] [Bug] [Pacts] Procedural guardian names on floors 250+ are excessively long #368

New Issue
Closed
opened 2026-06-10 19:29:53 +02:00 by Anexim · 2 comments
Anexim commented 2026-06-10 19:29:53 +02:00
Owner
Copy Link
Copy Source

Severity: Low
Type: Bug / UX
Store: usePrestigeStore / guardian-utils.ts

Steps to reproduce:

  1. Go to Debug tab → Pacts section
  2. Scroll down to floors 250+ in the guardian list

Expected:

  • Procedural guardian names should be concise and readable
  • Names should follow a consistent naming pattern

Actual:

  • Floors 250+ generate extremely long concatenated names like:
    • "Ignis-Petra-Steel-Pelag-Sah the Archon" (Floor 290)
    • "Ignis-Petra-Steel-Nimbus-Storm the Warden" (Floor 300)
    • "Terra-Marina-Siroc-Vulcan-Gale-Volt the Keeper" (Floor 310)
    • "Ignis-Arcana-Aero-Arc-Aur-Sol-Necro-Plague the Archon" (Floor 490)
  • These names are element abbreviations concatenated together, making them unreadable
  • The pattern appears to combine all element name prefixes into one string

Notes:

  • The procedural naming algorithm likely concatenates element prefixes without truncation or abbreviation
  • Consider limiting the number of elements shown in the name, or using a shorter naming scheme like "Dual-Element Guardian" or "Tri-Element Guardian" for complex combinations
  • This is a UX/readability issue rather than a functional bug
**Severity:** Low **Type:** Bug / UX **Store:** `usePrestigeStore` / `guardian-utils.ts` **Steps to reproduce:** 1. Go to Debug tab → Pacts section 2. Scroll down to floors 250+ in the guardian list **Expected:** - Procedural guardian names should be concise and readable - Names should follow a consistent naming pattern **Actual:** - Floors 250+ generate extremely long concatenated names like: - "Ignis-Petra-Steel-Pelag-Sah the Archon" (Floor 290) - "Ignis-Petra-Steel-Nimbus-Storm the Warden" (Floor 300) - "Terra-Marina-Siroc-Vulcan-Gale-Volt the Keeper" (Floor 310) - "Ignis-Arcana-Aero-Arc-Aur-Sol-Necro-Plague the Archon" (Floor 490) - These names are element abbreviations concatenated together, making them unreadable - The pattern appears to combine all element name prefixes into one string **Notes:** - The procedural naming algorithm likely concatenates element prefixes without truncation or abbreviation - Consider limiting the number of elements shown in the name, or using a shorter naming scheme like "Dual-Element Guardian" or "Tri-Element Guardian" for complex combinations - This is a UX/readability issue rather than a functional bug
Anexim added the ai:todo label 2026-06-10 19:29:53 +02:00
n8n-gitea was assigned by Anexim 2026-06-10 19:29:53 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-11 12:11:32 +02:00
Anexim commented 2026-06-11 12:11:32 +02:00
Author
Owner
Copy Link
Copy Source

Starting investigation of excessively long procedural guardian names on floors 250+. Reading guardian naming code.

Starting investigation of excessively long procedural guardian names on floors 250+. Reading guardian naming code.
Anexim added ai:done and removed ai:in-progress labels 2026-06-11 12:27:48 +02:00
Anexim commented 2026-06-11 12:27:48 +02:00
Author
Owner
Copy Link
Copy Source

Fix applied. The generateGuardianName function was receiving the full element chain from resolveMultiUnlockChain() (e.g. ['fire', 'earth', 'water', 'metal', 'sand'] for a Metal+Sand guardian), producing unreadable names like "Ignis-Petra-Marina-Steel-Sah the Archon".

Root cause: getProceduralGuardian passed g.element (the full expanded chain) directly to generateGuardianName.

Fix: Modified getProceduralGuardian to extract only the key elements per tier before name generation:

  • Tier 4 (dual base): first 2 elements
  • Tier 5 (dual composite): the 2 composite elements from the chain
  • Tier 6 (exotic): the 1 exotic element
  • Tier 7 (exotic+composite): 1 exotic + 1 composite
  • Tier 8 (full fusion): 1 exotic + 2 composites

Names are now concise (e.g. "Ferr-Arena the Warden" instead of "Ignis-Petra-Marina-Steel-Sah the Archon").

All 1158 tests pass.

**Fix applied.** The `generateGuardianName` function was receiving the full element chain from `resolveMultiUnlockChain()` (e.g. `['fire', 'earth', 'water', 'metal', 'sand']` for a Metal+Sand guardian), producing unreadable names like "Ignis-Petra-Marina-Steel-Sah the Archon". **Root cause:** `getProceduralGuardian` passed `g.element` (the full expanded chain) directly to `generateGuardianName`. **Fix:** Modified `getProceduralGuardian` to extract only the key elements per tier before name generation: - Tier 4 (dual base): first 2 elements - Tier 5 (dual composite): the 2 composite elements from the chain - Tier 6 (exotic): the 1 exotic element - Tier 7 (exotic+composite): 1 exotic + 1 composite - Tier 8 (full fusion): 1 exotic + 2 composites Names are now concise (e.g. "Ferr-Arena the Warden" instead of "Ignis-Petra-Marina-Steel-Sah the Archon"). All 1158 tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?