Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Cancelling pact ritual doesn't refund mana — permanent resource loss #370

New Issue
Closed
opened 2026-06-10 20:08:27 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-10 20:08:27 +02:00
Owner
Copy Link
Copy Source

Severity: Medium
File: src/lib/game/stores/prestigeStore.ts (lines 125-145 startPactRitual, 147-151 cancelPactRitual)

Description:
startPactRitual deducts guardian.pactCost raw mana upfront (line 136: manaStore.spendRawMana(guardian.pactCost)). However, if the player cancels the ritual via cancelPactRitual, the mana is not refunded — the function only resets pactRitualFloor and pactRitualProgress to null/0.

Impact: Cancelling a pact ritual permanently costs the player the full pact mana with no refund. This is unusual for a cancelable action and could be an unfair penalty, especially if cancelled by accident.

Fix needed: Refund the guardian.pactCost mana in cancelPactRitual when the ritual is cancelled.

**Severity:** Medium **File:** `src/lib/game/stores/prestigeStore.ts` (lines 125-145 startPactRitual, 147-151 cancelPactRitual) **Description:** `startPactRitual` deducts `guardian.pactCost` raw mana upfront (line 136: `manaStore.spendRawMana(guardian.pactCost)`). However, if the player cancels the ritual via `cancelPactRitual`, the mana is **not refunded** — the function only resets `pactRitualFloor` and `pactRitualProgress` to null/0. **Impact:** Cancelling a pact ritual permanently costs the player the full pact mana with no refund. This is unusual for a cancelable action and could be an unfair penalty, especially if cancelled by accident. **Fix needed:** Refund the `guardian.pactCost` mana in `cancelPactRitual` when the ritual is cancelled.
Anexim added the ai:todo label 2026-06-10 20:08:27 +02:00
n8n-gitea was assigned by Anexim 2026-06-10 20:08:27 +02:00
Anexim added ai:done and removed ai:todo labels 2026-06-11 11:38:05 +02:00
Anexim commented 2026-06-11 11:38:05 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: cancelPactRitual now refunds guardian.pactCost raw mana via useManaStore.setState when a ritual is cancelled.

Fixed: cancelPactRitual now refunds guardian.pactCost raw mana via useManaStore.setState when a ritual is cancelled.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?