Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Medium] [Bug] Spire enemy armor/barrier use Math.random() — non-deterministic, breaks save/load #371

New Issue
Closed
opened 2026-06-10 20:09:41 +02:00 by Anexim · 1 comment
Anexim commented 2026-06-10 20:09:41 +02:00
Owner
Copy Link
Copy Source

Severity: Medium
File: src/lib/game/utils/spire-utils.ts (lines 241-249, 251-261)

Description:
getSpireEnemyArmor and getSpireEnemyBarrier use Math.random() directly instead of a seeded PRNG. While generateSpireFloorState uses a seeded PRNG for room type/count, enemy stats are non-deterministic. This means save/load or re-render could produce different enemy armor values if the room is regenerated.

Impact: State desync on save/load; non-reproducible combat outcomes. Enemy stats may change between sessions.

Fix needed: Use the seeded PRNG (passed as a parameter or derived from the seed) instead of Math.random() for enemy stat generation.

**Severity:** Medium **File:** `src/lib/game/utils/spire-utils.ts` (lines 241-249, 251-261) **Description:** `getSpireEnemyArmor` and `getSpireEnemyBarrier` use `Math.random()` directly instead of a seeded PRNG. While `generateSpireFloorState` uses a seeded PRNG for room type/count, enemy stats are non-deterministic. This means save/load or re-render could produce different enemy armor values if the room is regenerated. **Impact:** State desync on save/load; non-reproducible combat outcomes. Enemy stats may change between sessions. **Fix needed:** Use the seeded PRNG (passed as a parameter or derived from the seed) instead of `Math.random()` for enemy stat generation.
Anexim added the ai:todo label 2026-06-10 20:09:41 +02:00
n8n-gitea was assigned by Anexim 2026-06-10 20:09:41 +02:00
Anexim added ai:done and removed ai:todo labels 2026-06-11 11:38:04 +02:00
Anexim commented 2026-06-11 11:38:04 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Replaced Math.random() with seeded PRNG (makeSeededRandom) in getSpireEnemyArmor and getSpireEnemyBarrier. Both functions now accept an optional seed parameter (defaults to floor-based seed for deterministic per-floor values).

Fixed: Replaced Math.random() with seeded PRNG (makeSeededRandom) in getSpireEnemyArmor and getSpireEnemyBarrier. Both functions now accept an optional seed parameter (defaults to floor-based seed for deterministic per-floor values).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?