Anexim/Mana-Loop
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Low] [Bug] Procedural guardian names duplicated across different floors #376

New Issue
Closed
opened 2026-06-11 23:36:29 +02:00 by Anexim · 3 comments
Anexim commented 2026-06-11 23:36:29 +02:00
Owner
Copy Link
Copy Source

Steps to reproduce:

  1. Go to Debug tab > Pacts section
  2. Scroll through the guardian list

Expected: Each guardian should have a unique name

Actual: Several guardians share the same or very similar names:

  • "Prism the Champion" appears at both Floor 170 (Crystal) and Floor 340 (Light+Earth+Water+Crystal)
  • "Prism-Stella-Null the Warden" at Floor 200 and "Prism-Stella-Null the Titan" at Floor 230
  • "Psy-Temp-Spark the Keeper" at Floor 210 and "Psy-Temp-Spark the Sovereign" at Floor 240

Likely cause: The procedural guardian naming algorithm in guardian-procedural.ts generates names based on element combinations, but doesn't check for uniqueness across floors.

Stores involved: data/guardian-procedural.ts

**Steps to reproduce:** 1. Go to Debug tab > Pacts section 2. Scroll through the guardian list **Expected:** Each guardian should have a unique name **Actual:** Several guardians share the same or very similar names: - "Prism the Champion" appears at both Floor 170 (Crystal) and Floor 340 (Light+Earth+Water+Crystal) - "Prism-Stella-Null the Warden" at Floor 200 and "Prism-Stella-Null the Titan" at Floor 230 - "Psy-Temp-Spark the Keeper" at Floor 210 and "Psy-Temp-Spark the Sovereign" at Floor 240 **Likely cause:** The procedural guardian naming algorithm in `guardian-procedural.ts` generates names based on element combinations, but doesn't check for uniqueness across floors. **Stores involved:** `data/guardian-procedural.ts`
Anexim added the ai:todo label 2026-06-11 23:36:29 +02:00
n8n-gitea was assigned by Anexim 2026-06-11 23:36:29 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-12 10:01:46 +02:00
Anexim commented 2026-06-12 10:01:46 +02:00
Author
Owner
Copy Link
Copy Source

Starting investigation. Bug: procedural guardian names duplicated across different floors. Reading guardian-procedural.ts to understand the naming algorithm.

Starting investigation. Bug: procedural guardian names duplicated across different floors. Reading guardian-procedural.ts to understand the naming algorithm.
Anexim commented 2026-06-12 10:02:48 +02:00
Author
Owner
Copy Link
Copy Source

Root Cause Identified

The generateGuardianName() function uses (floor + i) % prefixes.length for prefix and Math.floor(floor / 10) % titles.length for title. Both cycle with periods that create collisions:

  • Titles cycle every 100 floors (10 titles × 10 floors each)
  • Prefixes cycle every 50 floors for single-element floors (floor % 5)

This means single-element guardians at floors 170/370, 180/380, 210/420 etc. get identical names.

Examples verified:

  • Floor 170 (Crystal, Tier 3) → "Prism the Champion"
  • Floor 370 (Crystal, Tier 6) → "Prism the Champion" (same: 370%5=0→"Prism", 37%10=7→"Champion")

Fix Approach

Add a floor-offset modifier to the prefix selection in generateGuardianName — use (floor + i * 3 + Math.floor(floor / 50)) instead of (floor + i) to shift the prefix cycle so the same elements at different 100-floor cycles get different prefixes. This keeps names deterministic but unique per floor.

## Root Cause Identified The `generateGuardianName()` function uses `(floor + i) % prefixes.length` for prefix and `Math.floor(floor / 10) % titles.length` for title. Both cycle with periods that create collisions: - **Titles cycle every 100 floors** (10 titles × 10 floors each) - **Prefixes cycle every 50 floors** for single-element floors (`floor % 5`) This means single-element guardians at floors 170/370, 180/380, 210/420 etc. get identical names. **Examples verified:** - Floor 170 (Crystal, Tier 3) → "Prism the Champion" - Floor 370 (Crystal, Tier 6) → "Prism the Champion" (same: 370%5=0→"Prism", 37%10=7→"Champion") ## Fix Approach Add a **floor-offset modifier** to the prefix selection in `generateGuardianName` — use `(floor + i * 3 + Math.floor(floor / 50))` instead of `(floor + i)` to shift the prefix cycle so the same elements at different 100-floor cycles get different prefixes. This keeps names deterministic but unique per floor.
Anexim added ai:done and removed ai:in-progress labels 2026-06-12 10:06:05 +02:00
Anexim commented 2026-06-12 10:06:06 +02:00
Author
Owner
Copy Link
Copy Source

Fix Complete ✅

Changes

  • src/lib/game/data/guardian-encounters.ts — Modified generateGuardianName() to add a cycleOffset = Math.floor(floor / 50) that shifts prefix selection so the same elements at different 100-floor ranges produce different names. For multi-element names, the title is also shifted by cycleOffset.
  • src/lib/game/__tests__/guardian-names-unique.test.ts — New regression test with 7 test cases.

Verification

  • All 72 test files pass (1182 tests)
  • Pre-commit hooks pass (file sizes, tests, dependency graph)
  • Zero name collisions across all 49 guardian floors (10-490)
  • Names remain deterministic (same inputs → same output)

Specific fixes for reported collisions

Floor Before (buggy) After (fixed)
170 (Crystal) Prism the Champion Shard the Champion
370 (Crystal) Prism the Champion Crystal the Champion
200 (Crystal+Stellar+Void) Prism-Stella-Null the Warden Facet-Astro-Abyss the Sovereign
230 (Crystal+Stellar+Void) Prism-Stella-Null the Titan Facet-Astro-Abyss the Champion
210 (Soul+Time+Plasma) Psy-Temp-Spark the Keeper Wraith-Chron-Plasm the Guardian
240 (Soul+Time+Plasma) Psy-Temp-Spark the Sovereign Wraith-Chron-Plasm the Overlord

Commit: b68cc94

## Fix Complete ✅ ### Changes - **`src/lib/game/data/guardian-encounters.ts`** — Modified `generateGuardianName()` to add a `cycleOffset = Math.floor(floor / 50)` that shifts prefix selection so the same elements at different 100-floor ranges produce different names. For multi-element names, the title is also shifted by `cycleOffset`. - **`src/lib/game/__tests__/guardian-names-unique.test.ts`** — New regression test with 7 test cases. ### Verification - All 72 test files pass (1182 tests) - Pre-commit hooks pass (file sizes, tests, dependency graph) - Zero name collisions across all 49 guardian floors (10-490) - Names remain deterministic (same inputs → same output) ### Specific fixes for reported collisions | Floor | Before (buggy) | After (fixed) | |-------|----------------|---------------| | 170 (Crystal) | Prism the Champion | Shard the Champion | | 370 (Crystal) | Prism the Champion | Crystal the Champion | | 200 (Crystal+Stellar+Void) | Prism-Stella-Null the Warden | Facet-Astro-Abyss the Sovereign | | 230 (Crystal+Stellar+Void) | Prism-Stella-Null the Titan | Facet-Astro-Abyss the Champion | | 210 (Soul+Time+Plasma) | Psy-Temp-Spark the Keeper | Wraith-Chron-Plasm the Guardian | | 240 (Soul+Time+Plasma) | Psy-Temp-Spark the Sovereign | Wraith-Chron-Plasm the Overlord | Commit: `b68cc94`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#376
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?