Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

TASK-007: Duplicate stat functions across multiple modules — consolidate into computeStats() #4

New Issue
Closed
opened 2026-05-12 14:13:34 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-12 14:13:34 +02:00
Owner
Copy Link
Copy Source

Duplicate Stat Functions Need Consolidation

Multiple functions are duplicated across 3-4 locations. The new computeStats() in skills-v2.ts should be the single source, but old copies still exist and are used.

Duplicated functions:

Function Locations
computeMaxMana utils/mana-utils.ts, store-modules/computed-stats.ts, store/computed.ts, constants/skills-v2.ts (4 copies!)
computeRegen utils/mana-utils.ts, store-modules/computed-stats.ts, store/computed.ts (3 copies)
calcDamage utils/combat-utils.ts, store-modules/computed-stats.ts, store/computed.ts (3 copies)
getMeditationBonus utils/mana-utils.ts, store-modules/computed-stats.ts, store/computed.ts (3 copies)
getFloorMaxHP utils/floor-utils.ts, store/computed.ts (2 copies)
getFloorElement utils/floor-utils.ts, store/computed.ts (2 copies)
canAffordSpellCost utils/combat-utils.ts, store-modules/computed-stats.ts, store/computed.ts (3 copies)
fmt/fmtDec utils/formatting.ts, store/computed.ts (2 copies)

Plan:

  1. Make computeStats() in skills-v2.ts the single computation entry point
  2. computeMaxMana, computeRegen, computeClickMana should all come from applying computeStats() + prestige
  3. calcDamage, getMeditationBonus, etc. should read from ComputedStats output
  4. store/computed.ts should import from utils/ (not duplicate)
  5. store-modules/computed-stats.ts should import from utils/ (not duplicate)
  6. Delete duplicate functions once all callers are migrated

Acceptance criteria:

  • Each stat function exists in exactly one location
  • computeStats() is the foundation for mana/regen/click calculations
  • All tests pass with no regressions
## Duplicate Stat Functions Need Consolidation Multiple functions are duplicated across 3-4 locations. The new `computeStats()` in `skills-v2.ts` should be the single source, but old copies still exist and are used. ### Duplicated functions: | Function | Locations | |----------|----------| | `computeMaxMana` | `utils/mana-utils.ts`, `store-modules/computed-stats.ts`, `store/computed.ts`, `constants/skills-v2.ts` (4 copies!) | | `computeRegen` | `utils/mana-utils.ts`, `store-modules/computed-stats.ts`, `store/computed.ts` (3 copies) | | `calcDamage` | `utils/combat-utils.ts`, `store-modules/computed-stats.ts`, `store/computed.ts` (3 copies) | | `getMeditationBonus` | `utils/mana-utils.ts`, `store-modules/computed-stats.ts`, `store/computed.ts` (3 copies) | | `getFloorMaxHP` | `utils/floor-utils.ts`, `store/computed.ts` (2 copies) | | `getFloorElement` | `utils/floor-utils.ts`, `store/computed.ts` (2 copies) | | `canAffordSpellCost` | `utils/combat-utils.ts`, `store-modules/computed-stats.ts`, `store/computed.ts` (3 copies) | | `fmt`/`fmtDec` | `utils/formatting.ts`, `store/computed.ts` (2 copies) | ### Plan: 1. Make `computeStats()` in `skills-v2.ts` the single computation entry point 2. `computeMaxMana`, `computeRegen`, `computeClickMana` should all come from applying `computeStats()` + prestige 3. `calcDamage`, `getMeditationBonus`, etc. should read from `ComputedStats` output 4. `store/computed.ts` should import from `utils/` (not duplicate) 5. `store-modules/computed-stats.ts` should import from `utils/` (not duplicate) 6. Delete duplicate functions once all callers are migrated ### Acceptance criteria: - Each stat function exists in exactly one location - `computeStats()` is the foundation for mana/regen/click calculations - All tests pass with no regressions
Anexim added the ai:todo label 2026-05-12 14:13:34 +02:00
n8n-gitea was assigned by Anexim 2026-05-12 14:13:34 +02:00
Anexim commented 2026-05-16 11:59:30 +02:00
Author
Owner
Copy Link
Copy Source

Closed and replaced by Issue #15: Migrate Legacy Skills System to Active Disciplines. TASK-007 skill evolution consolidation is superseded by the new system.

Closed and replaced by Issue #15: Migrate Legacy Skills System to Active Disciplines. TASK-007 skill evolution consolidation is superseded by the new system.
Anexim removed the ai:todo label 2026-05-18 10:19:21 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?