Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: uiStore.ts has identical duplicate reset() and resetUI() functions #49

New Issue
Closed
opened 2026-05-18 16:02:34 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 16:02:34 +02:00
Owner
Copy Link
Copy Source

Severity: Minor

File: src/lib/game/stores/uiStore.ts (lines 56-73)

Problem: Both reset and resetUI do exactly the same thing — reset all UI state to initial values. This is dead code / unnecessary duplication.

Impact: Confusing for developers. Which one should be called?

Fix: Remove one of them and update all callers to use the remaining one.

**Severity:** Minor **File:** `src/lib/game/stores/uiStore.ts` (lines 56-73) **Problem:** Both `reset` and `resetUI` do exactly the same thing — reset all UI state to initial values. This is dead code / unnecessary duplication. **Impact:** Confusing for developers. Which one should be called? **Fix:** Remove one of them and update all callers to use the remaining one.
Anexim added the ai:todo label 2026-05-18 16:02:34 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 16:02:34 +02:00
Anexim commented 2026-05-18 17:12:06 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 1] CLEANUP — uiStore.ts has identical duplicate reset() and resetUI() functions.

[priority: 1] CLEANUP — uiStore.ts has identical duplicate reset() and resetUI() functions.
Anexim commented 2026-05-18 20:58:25 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Removed duplicate resetUI() function from uiStore.ts. Updated caller in gameActions.ts to use reset() instead.

Fixed: Removed duplicate resetUI() function from uiStore.ts. Updated caller in gameActions.ts to use reset() instead.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?