🔴 DisciplinesTab: canProceedDiscipline called with wrong arguments #52

New Issue

2026-05-18T17:06:36+02:00

Anexim commented

2026-05-18 17:06:36 +02:00

File: src/lib/game/stores/discipline-slice.ts, line 61

if (!canProceedDiscipline(id, gameState)) return s;

The function canProceedDiscipline in src/lib/game/utils/discipline-math.ts (line 65) expects 3 arguments:

canProceedDiscipline(
  discipline: DisciplineDefinition,
  disciplineState: DisciplineState,
  gameState: { elements?: Record<string, any>; rawMana?: number }
)

But the store call passes only 2 arguments (id: string and gameState), passing a string where a DisciplineDefinition object is expected, and omitting the disciplineState parameter entirely.

Impact: Runtime crash — discipline.manaType will fail on a string value. Discipline activation will never work correctly.

Fix: Look up the discipline definition and state before calling:

const def = DISCIPLINE_MAP[id];
const discState = s.disciplines[id];
if (!canProceedDiscipline(def, discState, gameState)) return s;

**File:** `src/lib/game/stores/discipline-slice.ts`, line 61 ```ts if (!canProceedDiscipline(id, gameState)) return s; ``` The function `canProceedDiscipline` in `src/lib/game/utils/discipline-math.ts` (line 65) expects **3 arguments**: ```ts canProceedDiscipline( discipline: DisciplineDefinition, disciplineState: DisciplineState, gameState: { elements?: Record<string, any>; rawMana?: number } ) ``` But the store call passes only **2 arguments** (`id: string` and `gameState`), passing a string where a `DisciplineDefinition` object is expected, and omitting the `disciplineState` parameter entirely. **Impact:** Runtime crash — `discipline.manaType` will fail on a string value. Discipline activation will never work correctly. **Fix:** Look up the discipline definition and state before calling: ```ts const def = DISCIPLINE_MAP[id]; const discState = s.disciplines[id]; if (!canProceedDiscipline(def, discState, gameState)) return s; ```

Anexim added the ai:todo label 2026-05-18 17:06:36 +02:00

n8n-gitea was assigned by Anexim

2026-05-18 17:06:36 +02:00

Anexim commented

2026-05-18 17:09:49 +02:00

[priority: 5] CRASH/BLOCKER — canProceedDiscipline called with wrong arguments, crashes DisciplinesTab.

Anexim referenced this issue

2026-05-18 17:13:10 +02:00

📋 Project-wide issue prioritization complete — 36 issues ranked [priority: 1-5] #66

Anexim closed this issue

2026-05-18 17:49:36 +02:00

Anexim commented

2026-05-18 17:49:37 +02:00

Fixed: In discipline-slice.ts activate(), now correctly looks up discState = s.disciplines[id] and passes (def, discState, gameState) to canProceedDiscipline() instead of (id, gameState).

Fixed: In discipline-slice.ts `activate()`, now correctly looks up `discState = s.disciplines[id]` and passes `(def, discState, gameState)` to `canProceedDiscipline()` instead of `(id, gameState)`.

n8n-gitea referenced this issue from a commit

2026-05-18 17:51:15 +02:00

fix: resolve all Priority 5 CRASH/BLOCKER issues (#51-#57)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#52

🔴 DisciplinesTab: canProceedDiscipline called with wrong arguments #52

🔴 DisciplinesTab: `canProceedDiscipline` called with wrong arguments #52