Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

🟡 DisciplinesTab: tab filtering broken — all attunements render simultaneously #56

New Issue
Closed
opened 2026-05-18 17:06:38 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 17:06:38 +02:00
Owner
Copy Link
Copy Source

File: src/components/game/tabs/DisciplinesTab.tsx, lines 207-232

The grid renders cards from all attunementTabs simultaneously. The visibility check:

const isVisible = attunementTabs.find((t) => t.label === tab.label)?.items === tab.items;

compares array references, which is always true since it's the same array. There is no actual tab filtering — all discipline cards from all attunements are always shown.

Impact: The attunement tab bar is purely decorative. Users see all disciplines from all attunements at once regardless of which tab is selected.

Fix: Track the selected tab in state and filter the rendered cards to only show disciplines from the selected attunement.

**File:** `src/components/game/tabs/DisciplinesTab.tsx`, lines 207-232 The grid renders cards from **all** `attunementTabs` simultaneously. The visibility check: ```ts const isVisible = attunementTabs.find((t) => t.label === tab.label)?.items === tab.items; ``` compares array references, which is always `true` since it's the same array. There is no actual tab filtering — all discipline cards from all attunements are always shown. **Impact:** The attunement tab bar is purely decorative. Users see all disciplines from all attunements at once regardless of which tab is selected. **Fix:** Track the selected tab in state and filter the rendered cards to only show disciplines from the selected attunement.
Anexim added the ai:todo label 2026-05-18 17:06:38 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 17:06:38 +02:00
Anexim commented 2026-05-18 17:10:42 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 4] BROKEN FEATURE — DisciplinesTab tab filtering broken, all attunements render simultaneously.

[priority: 4] BROKEN FEATURE — DisciplinesTab tab filtering broken, all attunements render simultaneously.
Anexim commented 2026-05-18 19:51:57 +02:00
Author
Owner
Copy Link
Copy Source

Verified fixed. The DisciplinesTab now tracks activeAttunement state and renders only activeTab?.items instead of all attunement tabs simultaneously. The tab bar correctly filters discipline cards by selected attunement.

Verified fixed. The DisciplinesTab now tracks `activeAttunement` state and renders only `activeTab?.items` instead of all attunement tabs simultaneously. The tab bar correctly filters discipline cards by selected attunement.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#56
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?