TASK-007: Remove legacy skill-evolution-modules/ and skill-evolution.ts after migration #6

Closed
opened 2026-05-12 14:14:48 +02:00 by Anexim · 1 comment
Owner

Delete Legacy Skill System Files

The migration to computeStats() (Phase 1) is incomplete. The old system still exists and causes confusion:

Files to delete after full migration:

  1. src/lib/game/skill-evolution-modules/ — entire directory (17 files, ~120KB)
    • index.ts (SKILL_EVOLUTION_PATHS + helpers)
    • elemental-attunement.ts, enchanting-skills.ts, focused-mind.ts
    • guardian-skills.ts, hybrid-skills.ts, insight-harvest.ts
    • invocation-skills.ts, knowledge-retention.ts, learning-skills.ts
    • magic-skills.ts, mana-utility-skills.ts, mana-well-flow.ts
    • quick-learner.ts, types.ts, utils.ts
  2. src/lib/game/skill-evolution.ts — re-export wrapper
  3. src/lib/game/skill-evolution.ts.fix — backup file, delete

Prerequisites before deleting:

  • All evolution paths for SKILLS_V2 skills are defined in the new system
  • computeStats() is the single stat computation at runtime
  • gameStore.ts no longer references skill-evolution
  • upgrade-effects.ts no longer references SKILL_EVOLUTION_PATHS
  • All tests pass without legacy modules

Current blockers:

  • src/lib/game/upgrade-effects.ts imports SKILL_EVOLUTION_PATHS from skill-evolution (line 3)
  • src/lib/game/__tests__/skill-system.test.ts imports from skill-evolution
  • src/lib/game/skillStore.ts imports from skill-evolution

Acceptance criteria:

  • Zero imports of skill-evolution or skill-evolution-modules anywhere
  • All files deleted from both locations
  • All tests pass
## Delete Legacy Skill System Files The migration to `computeStats()` (Phase 1) is incomplete. The old system still exists and causes confusion: ### Files to delete after full migration: 1. `src/lib/game/skill-evolution-modules/` — entire directory (17 files, ~120KB) - `index.ts` (SKILL_EVOLUTION_PATHS + helpers) - `elemental-attunement.ts`, `enchanting-skills.ts`, `focused-mind.ts` - `guardian-skills.ts`, `hybrid-skills.ts`, `insight-harvest.ts` - `invocation-skills.ts`, `knowledge-retention.ts`, `learning-skills.ts` - `magic-skills.ts`, `mana-utility-skills.ts`, `mana-well-flow.ts` - `quick-learner.ts`, `types.ts`, `utils.ts` 2. `src/lib/game/skill-evolution.ts` — re-export wrapper 3. `src/lib/game/skill-evolution.ts.fix` — backup file, delete ### Prerequisites before deleting: - [ ] All evolution paths for SKILLS_V2 skills are defined in the new system - [ ] `computeStats()` is the single stat computation at runtime - [ ] `gameStore.ts` no longer references `skill-evolution` - [ ] `upgrade-effects.ts` no longer references `SKILL_EVOLUTION_PATHS` - [ ] All tests pass without legacy modules ### Current blockers: - `src/lib/game/upgrade-effects.ts` imports `SKILL_EVOLUTION_PATHS` from `skill-evolution` (line 3) - `src/lib/game/__tests__/skill-system.test.ts` imports from `skill-evolution` - `src/lib/game/skillStore.ts` imports from `skill-evolution` ### Acceptance criteria: - Zero imports of `skill-evolution` or `skill-evolution-modules` anywhere - All files deleted from both locations - All tests pass
Anexim added the ai:todo label 2026-05-12 14:14:48 +02:00
n8n-gitea was assigned by Anexim 2026-05-12 14:14:48 +02:00
Author
Owner

Closed and replaced by Issue #15: Migrate Legacy Skills System to Active Disciplines. This issue was part of the old TASK-007 skill evolution system which is now fully replaced.

Closed and replaced by Issue #15: Migrate Legacy Skills System to Active Disciplines. This issue was part of the old TASK-007 skill evolution system which is now fully replaced.
Anexim removed the ai:todo label 2026-05-18 10:19:21 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#6