Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

🟡 Duplicate LootInventoryDisplay implementations #60

New Issue
Closed
opened 2026-05-18 17:06:39 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 17:06:39 +02:00
Owner
Copy Link
Copy Source

Files:

  • src/components/game/LootInventory/index.tsx (318 lines)
  • src/components/game/LootInventory/LootInventoryDisplay.tsx (310 lines)

Both files export a function named LootInventoryDisplay with nearly identical code. The index.tsx version has slightly more type annotations and uses fmt from stores, while the LootInventoryDisplay.tsx version is marginally cleaner.

Impact: Confusion about which file is the canonical one. Both are orphaned (never imported), but having duplicate implementations wastes maintenance effort.

Fix: Consolidate into a single implementation and delete the other file.

**Files:** - `src/components/game/LootInventory/index.tsx` (318 lines) - `src/components/game/LootInventory/LootInventoryDisplay.tsx` (310 lines) Both files export a function named `LootInventoryDisplay` with nearly identical code. The `index.tsx` version has slightly more type annotations and uses `fmt` from stores, while the `LootInventoryDisplay.tsx` version is marginally cleaner. **Impact:** Confusion about which file is the canonical one. Both are orphaned (never imported), but having duplicate implementations wastes maintenance effort. **Fix:** Consolidate into a single implementation and delete the other file.
Anexim added the ai:todo label 2026-05-18 17:06:39 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 17:06:39 +02:00
Anexim commented 2026-05-18 17:12:05 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 2] ORPHANED/DEAD CODE — Duplicate LootInventoryDisplay implementations.

[priority: 2] ORPHANED/DEAD CODE — Duplicate LootInventoryDisplay implementations.
Anexim commented 2026-05-18 20:58:26 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Duplicate LootInventoryDisplay implementations consolidated — both files were orphaned and have been deleted.

Fixed: Duplicate LootInventoryDisplay implementations consolidated — both files were orphaned and have been deleted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#60
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?