Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

🟡 ConfirmDialog: dead code — fully implemented but never imported #61

New Issue
Closed
opened 2026-05-18 17:06:39 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-18 17:06:39 +02:00
Owner
Copy Link
Copy Source

File: src/components/game/ConfirmDialog.tsx (184 lines)

ConfirmDialog is a fully implemented confirmation dialog component with useConfirmDialog hook and ConfirmDialogVariant type. It exports ConfirmDialog, useConfirmDialog, and has a default export. However, no file in the codebase imports it. The EnchantmentPreparer that needs confirmation dialogs uses raw shadcn AlertDialog instead.

Impact: Dead code. 184 lines of unused component.

Fix: Either integrate ConfirmDialog where confirmation dialogs are needed (replacing raw AlertDialog usage), or remove it.

**File:** `src/components/game/ConfirmDialog.tsx` (184 lines) `ConfirmDialog` is a fully implemented confirmation dialog component with `useConfirmDialog` hook and `ConfirmDialogVariant` type. It exports `ConfirmDialog`, `useConfirmDialog`, and has a default export. However, **no file in the codebase imports it**. The `EnchantmentPreparer` that needs confirmation dialogs uses raw shadcn `AlertDialog` instead. **Impact:** Dead code. 184 lines of unused component. **Fix:** Either integrate `ConfirmDialog` where confirmation dialogs are needed (replacing raw `AlertDialog` usage), or remove it.
Anexim added the ai:todo label 2026-05-18 17:06:39 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 17:06:39 +02:00
Anexim commented 2026-05-18 17:12:05 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 2] ORPHANED/DEAD CODE — ConfirmDialog fully implemented but never imported.

[priority: 2] ORPHANED/DEAD CODE — ConfirmDialog fully implemented but never imported.
Anexim commented 2026-05-18 20:58:26 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Deleted orphaned ConfirmDialog.tsx (never imported — EnchantmentPreparer uses AlertDialog from shadcn instead).

Fixed: Deleted orphaned ConfirmDialog.tsx (never imported — EnchantmentPreparer uses AlertDialog from shadcn instead).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#61
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?