[priority: 4] calcDamage called with empty skills — all skill-based damage bonuses ignored in combat #72

New Issue

2026-05-19T09:09:47+02:00

Anexim commented

2026-05-19 09:09:47 +02:00

Severity: 4 — High
File: src/lib/game/stores/combat-actions.ts, lines 57-59

Description:
calcDamage is called with an empty skills object:

const damage = calcDamage(
  { skills: {}, signedPacts: usePrestigeStore.getState().signedPacts },
  spellId,
  floorElement,
);

calcDamage applies skill bonuses from combatTrain, arcaneFury, elementalMastery, guardianBane, and precision. But skills is always {}, so all skill-based damage bonuses are completely non-functional during combat.

Fix: Pass actual skill state to processCombatTick and forward it to calcDamage.

**Severity:** 4 — High **File:** `src/lib/game/stores/combat-actions.ts`, lines 57-59 **Description:** `calcDamage` is called with an empty skills object: ```ts const damage = calcDamage( { skills: {}, signedPacts: usePrestigeStore.getState().signedPacts }, spellId, floorElement, ); ``` `calcDamage` applies skill bonuses from `combatTrain`, `arcaneFury`, `elementalMastery`, `guardianBane`, and `precision`. But `skills` is always `{}`, so **all skill-based damage bonuses are completely non-functional during combat**. **Fix:** Pass actual skill state to `processCombatTick` and forward it to `calcDamage`.

Anexim added the ai:todo label 2026-05-19 09:09:47 +02:00

n8n-gitea was assigned by Anexim

2026-05-19 09:09:47 +02:00

Anexim commented

2026-05-19 12:58:07 +02:00

Starting work on Issue 72: calcDamage called with empty skills — all skill-based damage bonuses ignored in combat. This is part of the skill→discipline migration gap. Will wire discipline effects into calcDamage and other utility functions that currently accept empty skill objects.

Anexim closed this issue

2026-05-19 13:47:07 +02:00

Anexim commented

2026-05-19 13:47:08 +02:00

Fixed: Updated calcDamage in combat-utils.ts to accept an optional DisciplineBonuses parameter. Discipline bonuses from spell-casting (baseDamageBonus) and void-manipulation (baseDamageMultiplier) are now applied to damage calculations. Updated combat-actions.ts to compute discipline effects once per tick and pass them to both calcDamage calls.

Fixed: Updated `calcDamage` in `combat-utils.ts` to accept an optional `DisciplineBonuses` parameter. Discipline bonuses from `spell-casting` (baseDamageBonus) and `void-manipulation` (baseDamageMultiplier) are now applied to damage calculations. Updated `combat-actions.ts` to compute discipline effects once per tick and pass them to both `calcDamage` calls.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#72