[priority: 3] createGatherMana hardcodes click mana to 1 — ignores all skill/upgrade bonuses #76

New Issue

2026-05-19T09:11:17+02:00

Anexim commented

2026-05-19 09:11:17 +02:00

Severity: 3 — Medium
File: src/lib/game/stores/gameActions.ts, lines 33-48

Description:
Click mana is hardcoded to 1 and computeClickMana is never called:

const cm = 1;  // Hardcoded!
const max = computeMaxMana(
  { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {} },
  undefined
);
useManaStore.getState().gatherMana(cm, max);

The computeClickMana function adds bonuses from manaTap and manaSurge skills, but it's never invoked. Also, computeMaxMana is called with empty skill objects, so skill-based max mana bonuses don't apply either. Click mana always gives exactly 1 mana regardless of upgrades.

Fix: Call computeClickMana with actual skill state and pass the result to gatherMana.

**Severity:** 3 — Medium **File:** `src/lib/game/stores/gameActions.ts`, lines 33-48 **Description:** Click mana is hardcoded to `1` and `computeClickMana` is never called: ```ts const cm = 1; // Hardcoded! const max = computeMaxMana( { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {} }, undefined ); useManaStore.getState().gatherMana(cm, max); ``` The `computeClickMana` function adds bonuses from `manaTap` and `manaSurge` skills, but it's never invoked. Also, `computeMaxMana` is called with empty skill objects, so skill-based max mana bonuses don't apply either. **Click mana always gives exactly 1 mana regardless of upgrades.** **Fix:** Call `computeClickMana` with actual skill state and pass the result to `gatherMana`.

Anexim added the ai:todo label 2026-05-19 09:11:17 +02:00

n8n-gitea was assigned by Anexim

2026-05-19 09:11:17 +02:00

Anexim commented

2026-05-19 12:58:08 +02:00

Starting work on Issue 76: createGatherMana hardcodes click mana to 1 — ignores all skill/upgrade bonuses. Part of the same skill→discipline migration gap.

Anexim closed this issue

2026-05-19 13:47:08 +02:00

Anexim commented

2026-05-19 13:47:08 +02:00

Fixed: Updated createGatherMana in gameActions.ts to use computeClickMana with discipline effects instead of hardcoding click mana to 1. The mana-channeling discipline's clickManaMultiplier bonus is now applied. Also updated computeMaxMana call to pass discipline effects.

Fixed: Updated `createGatherMana` in `gameActions.ts` to use `computeClickMana` with discipline effects instead of hardcoding click mana to 1. The `mana-channeling` discipline's `clickManaMultiplier` bonus is now applied. Also updated `computeMaxMana` call to pass discipline effects.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#76