[priority: 3] tick() passes empty skill objects to computeMaxMana/computeRegen — skill bonuses ignored #77

New Issue

2026-05-19T09:11:17+02:00

Anexim commented

2026-05-19 09:11:17 +02:00

Severity: 3 — Medium
File: src/lib/game/stores/gameStore.ts, lines 76-84

Description:
Skills, skillUpgrades, and skillTiers are all passed as empty objects {}:

const maxMana = computeMaxMana(
  { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {} },
  undefined
);
const baseRegen = computeRegen(
  { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {}, attunement: {} },
  undefined
);

Skill-based mana and regen bonuses are completely ignored during the game tick. Only prestige upgrades affect max mana and regen.

Fix: Pass actual skill state from the appropriate store.

**Severity:** 3 — Medium **File:** `src/lib/game/stores/gameStore.ts`, lines 76-84 **Description:** Skills, skillUpgrades, and skillTiers are all passed as empty objects `{}`: ```ts const maxMana = computeMaxMana( { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {} }, undefined ); const baseRegen = computeRegen( { skills: {}, prestigeUpgrades: prestigeState.prestigeUpgrades, skillUpgrades: {}, skillTiers: {}, attunement: {} }, undefined ); ``` **Skill-based mana and regen bonuses are completely ignored during the game tick.** Only prestige upgrades affect max mana and regen. **Fix:** Pass actual skill state from the appropriate store.

Anexim added the ai:todo label 2026-05-19 09:11:17 +02:00

n8n-gitea was assigned by Anexim

2026-05-19 09:11:17 +02:00

Anexim commented

2026-05-19 12:58:08 +02:00

Starting work on Issue 77: tick() passes empty skill objects to computeMaxMana/computeRegen — skill bonuses ignored. Part of the same skill→discipline migration gap.

Anexim closed this issue

2026-05-19 13:47:08 +02:00

Anexim commented

2026-05-19 13:47:08 +02:00

Fixed: Updated tick() in gameStore.ts to pass discipline effects to computeMaxMana, computeRegen, and calcInsight. The raw-mastery discipline's maxManaBonus now contributes to max mana calculation. Also updated gameLoopActions.ts to pass discipline effects to calcInsight.

Fixed: Updated `tick()` in `gameStore.ts` to pass discipline effects to `computeMaxMana`, `computeRegen`, and `calcInsight`. The `raw-mastery` discipline's `maxManaBonus` now contributes to max mana calculation. Also updated `gameLoopActions.ts` to pass discipline effects to `calcInsight`.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#77