Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

[priority: 3] startDesigningEnchantment never uses designProgress2 slot (Enchant Mastery broken) #79

New Issue
Closed
opened 2026-05-19 09:11:18 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-19 09:11:18 +02:00
Owner
Copy Link
Copy Source

Severity: 3 — Medium
File: src/lib/game/stores/craftingStore.ts and src/lib/game/crafting-actions/design-actions.ts

Description:
startDesigningEnchantment only checks if designProgress (slot 1) is free. If slot 1 is occupied but designProgress2 (slot 2, from Enchant Mastery) is free, the function returns false instead of using the second slot. The designProgress2 slot is never used for new designs.

Fix: Add an else if (!state.designProgress2) branch to use the second design slot.

**Severity:** 3 — Medium **File:** `src/lib/game/stores/craftingStore.ts` and `src/lib/game/crafting-actions/design-actions.ts` **Description:** `startDesigningEnchantment` only checks if `designProgress` (slot 1) is free. If slot 1 is occupied but `designProgress2` (slot 2, from Enchant Mastery) is free, the function returns `false` instead of using the second slot. The `designProgress2` slot is never used for new designs. **Fix:** Add an `else if (!state.designProgress2)` branch to use the second design slot.
Anexim added the ai:todo label 2026-05-19 09:11:18 +02:00
n8n-gitea was assigned by Anexim 2026-05-19 09:11:18 +02:00
Anexim commented 2026-05-19 11:05:05 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on startDesigningEnchantment slot 2 fix.

Starting work on startDesigningEnchantment slot 2 fix.
Anexim commented 2026-05-19 11:23:15 +02:00
Author
Owner
Copy Link
Copy Source

✅ Fixed. Added else if (!state.designProgress2) branch to startDesigningEnchantment in craftingStore.ts. When slot 1 is occupied, new designs now correctly use slot 2. Previously the function returned false even when slot 2 was free. Regression tests added.

✅ Fixed. Added `else if (!state.designProgress2)` branch to `startDesigningEnchantment` in `craftingStore.ts`. When slot 1 is occupied, new designs now correctly use slot 2. Previously the function returned `false` even when slot 2 was free. Regression tests added.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#79
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?