Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

[priority: 3] Mana Tide pulse factor incorrect — ranges 0.5x-1.0x instead of 0.5x-1.5x #83

New Issue
Closed
opened 2026-05-19 09:11:19 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-19 09:11:19 +02:00
Owner
Copy Link
Copy Source

Severity: 3 — Medium
File: src/lib/game/effects/dynamic-compute.ts, lines 68-71

Description:

const pulseFactor = 0.5 + 0.5 * Math.sin(Date.now() / 10000);
regen *= (0.5 + pulseFactor * 0.5);

pulseFactor ranges from 0 to 1. Then regen *= (0.5 + pulseFactor * 0.5) means regen is multiplied by 0.5 to 1.0. The comment says "Regen pulses ±50%" which should range from 0.5x to 1.5x. The current formula only pulses -50% to 0%.

Fix: Change to regen *= (1.0 + 0.5 * Math.sin(Date.now() / 10000)) to get 0.5x to 1.5x.

**Severity:** 3 — Medium **File:** `src/lib/game/effects/dynamic-compute.ts`, lines 68-71 **Description:** ```ts const pulseFactor = 0.5 + 0.5 * Math.sin(Date.now() / 10000); regen *= (0.5 + pulseFactor * 0.5); ``` `pulseFactor` ranges from 0 to 1. Then `regen *= (0.5 + pulseFactor * 0.5)` means regen is multiplied by 0.5 to 1.0. The comment says "Regen pulses ±50%" which should range from 0.5x to 1.5x. The current formula only pulses -50% to 0%. **Fix:** Change to `regen *= (1.0 + 0.5 * Math.sin(Date.now() / 10000))` to get 0.5x to 1.5x.
Anexim added the ai:todo label 2026-05-19 09:11:19 +02:00
n8n-gitea was assigned by Anexim 2026-05-19 09:11:19 +02:00
Anexim commented 2026-05-19 11:05:04 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on Mana Tide pulse factor fix.

Starting work on Mana Tide pulse factor fix.
Anexim commented 2026-05-19 11:23:13 +02:00
Author
Owner
Copy Link
Copy Source

✅ Fixed. Changed regen *= (0.5 + pulseFactor * 0.5) to regen *= (1.0 + 0.5 * Math.sin(Date.now() / 10000)) in src/lib/game/effects/dynamic-compute.ts. Pulse now correctly ranges 0.5x-1.5x. Regression tests added.

✅ Fixed. Changed `regen *= (0.5 + pulseFactor * 0.5)` to `regen *= (1.0 + 0.5 * Math.sin(Date.now() / 10000))` in `src/lib/game/effects/dynamic-compute.ts`. Pulse now correctly ranges 0.5x-1.5x. Regression tests added.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#83
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?