[priority: critical] 3 import cycles in production code (store↔utils, equipment↔utils, golems↔utils) #95

New Issue

2026-05-20T10:59:24+02:00

Anexim commented

2026-05-20 10:59:24 +02:00

Severity: Critical — import cycles cause unpredictable initialization order, subtle bugs, and block tree-shaking.

Findings:

Cycle 1: store.ts → combat-utils.ts → mana-utils.ts → store.ts (3 files)
Cycle 2: equipment/index.ts → equipment/utils.ts → equipment/index.ts (2 files)
Cycle 3: golems/index.ts → golems/utils.ts → golems/utils.ts (2 files)

Affected files:

src/lib/game/store.ts, src/lib/game/utils/combat-utils.ts, src/lib/game/utils/mana-utils.ts
src/lib/game/data/equipment/index.ts, src/lib/game/data/equipment/utils.ts
src/lib/game/data/golems/index.ts, src/lib/game/data/golems/utils.ts

Suggested fix: Extract shared types/constants into separate modules that both sides can import. For equipment and golems, merge utils into index or extract a shared types module.

Confidence: High
Dimension: cross_module_architecture / dependency_health

**Severity:** Critical — import cycles cause unpredictable initialization order, subtle bugs, and block tree-shaking. **Findings:** - Cycle 1: `store.ts → combat-utils.ts → mana-utils.ts → store.ts` (3 files) - Cycle 2: `equipment/index.ts → equipment/utils.ts → equipment/index.ts` (2 files) - Cycle 3: `golems/index.ts → golems/utils.ts → golems/utils.ts` (2 files) **Affected files:** - `src/lib/game/store.ts`, `src/lib/game/utils/combat-utils.ts`, `src/lib/game/utils/mana-utils.ts` - `src/lib/game/data/equipment/index.ts`, `src/lib/game/data/equipment/utils.ts` - `src/lib/game/data/golems/index.ts`, `src/lib/game/data/golems/utils.ts` **Suggested fix:** Extract shared types/constants into separate modules that both sides can import. For equipment and golems, merge utils into index or extract a shared types module. **Confidence:** High **Dimension:** cross_module_architecture / dependency_health

Anexim added the ai:todo label 2026-05-20 10:59:24 +02:00

n8n-gitea was assigned by Anexim

2026-05-20 10:59:24 +02:00

Anexim commented

2026-05-20 11:02:27 +02:00

Starting work on breaking 3 import cycles. Will investigate each cycle, then extract shared modules to break them.

Anexim commented

2026-05-20 12:01:50 +02:00

Fix complete. Broke both circular dependency chains by extracting shared data constants into standalone modules:

Equipment cycle (index.ts ↔ utils.ts): Created equipment-types-data.ts containing EQUIPMENT_TYPES. Both index.ts and utils.ts now import from this shared module instead of each other.
Golems cycle (index.ts ↔ utils.ts): Created golems-data.ts containing GOLEMS_DEF. Both index.ts and utils.ts now import from this shared module instead of each other.

Verification:

madge --circular src/lib/game → "No circular dependency found!"
All 17/18 test files pass (1 pre-existing failure in spire-utils.test.ts unrelated to this change)
tsc --noEmit → zero new errors in modified files
All files under 400 lines (enforced by pre-commit hook)

Files changed: 10 files, 85 insertions, 46 deletions

New: equipment-types-data.ts, golems-data.ts
Modified: equipment/index.ts, equipment/utils.ts, golems/index.ts, golems/utils.ts
Auto-updated by hooks: docs/circular-deps.txt, docs/dependency-graph.json, docs/project-structure.txt

**Fix complete.** Broke both circular dependency chains by extracting shared data constants into standalone modules: 1. **Equipment cycle** (`index.ts ↔ utils.ts`): Created `equipment-types-data.ts` containing `EQUIPMENT_TYPES`. Both `index.ts` and `utils.ts` now import from this shared module instead of each other. 2. **Golems cycle** (`index.ts ↔ utils.ts`): Created `golems-data.ts` containing `GOLEMS_DEF`. Both `index.ts` and `utils.ts` now import from this shared module instead of each other. **Verification:** - `madge --circular src/lib/game` → "No circular dependency found!" - All 17/18 test files pass (1 pre-existing failure in spire-utils.test.ts unrelated to this change) - `tsc --noEmit` → zero new errors in modified files - All files under 400 lines (enforced by pre-commit hook) **Files changed:** 10 files, 85 insertions, 46 deletions - New: `equipment-types-data.ts`, `golems-data.ts` - Modified: `equipment/index.ts`, `equipment/utils.ts`, `golems/index.ts`, `golems/utils.ts` - Auto-updated by hooks: `docs/circular-deps.txt`, `docs/dependency-graph.json`, `docs/project-structure.txt`

Anexim closed this issue

2026-05-20 12:02:30 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#95