fix: correct circular dep detection in pre-commit hook
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
The generate-dependency-graph.js script was counting madge's 'Processed N files' info line as a circular chain. Fixed the filter to only match lines starting with 'N)' pattern.
This commit is contained in:
+2
-16
@@ -1,18 +1,4 @@
|
||||
# Circular Dependencies
|
||||
Generated: $(date -u +"%Y-%m-%dT%H:%M:%S.%3NZ")
|
||||
Found: 0 circular chain(s) — clean!
|
||||
Generated: 2026-05-26T19:57:33.588Z
|
||||
|
||||
## Status
|
||||
All 7 previously-known circular dependency chains have been resolved:
|
||||
1. ✅ effects/discipline-effects.ts > stores/discipline-slice.ts > stores/combatStore.ts > stores/combat-actions.ts
|
||||
- Fixed by: discipline-slice.ts uses callbacks instead of directly importing combatStore
|
||||
2. ✅ utils/floor-utils.ts > utils/room-utils.ts > utils/enemy-utils.ts
|
||||
- Fixed by: removed re-export of getDodgeChance from floor-utils.ts
|
||||
3. ✅ utils/floor-utils.ts > utils/room-utils.ts
|
||||
- Fixed by: same as above
|
||||
4. ✅ stores/gameStore.ts > stores/gameActions.ts
|
||||
- Fixed by: extracted GameCoordinatorState to gameStore.types.ts
|
||||
5. ✅ stores/gameStore.ts > stores/gameLoopActions.ts
|
||||
- Fixed by: extracted GameCoordinatorState to gameStore.types.ts
|
||||
6. ✅ stores/gameStore.ts > stores/tick-pipeline.ts
|
||||
- Fixed by: extracted GameCoordinatorState to gameStore.types.ts
|
||||
No circular dependencies found. ✅
|
||||
|
||||
Reference in New Issue
Block a user