Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[medium] Discipline UI doesn't show which mana types are consumed during practice #132

New Issue
Closed
opened 2026-05-25 11:36:12 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-25 11:36:12 +02:00
Owner
Copy Link
Copy Source

UI Issue: Unclear what mana types are drained when practicing a discipline

Description

When a player looks at a discipline card, it's not obvious which mana type will be consumed while practicing. The manaType field exists in the data model but is never displayed in the UI.

Current State

  • DisciplineDefinition.manaType exists and is used in discipline-slice.ts processTick() to determine which mana pool to drain
  • The DisciplineCardDefinition interface in DisciplinesTab.tsx does NOT include manaType
  • The DisciplineCard component never renders the mana type
  • Players must guess or external-reference which mana type a discipline uses

Expected Behavior

Each discipline card should prominently display:

  • The primary mana type consumed (e.g., "🔥 Fire", "💧 Water", "🔗 Transference")
  • Use the element's emoji/symbol and color from ELEMENTS constants
  • If a discipline uses raw mana, show "⚪ Raw Mana"
  • Consider also showing the drain rate in context of the mana type (e.g., "Drains 2.5 🔥/tick")

Files Involved

  • src/components/game/tabs/DisciplinesTab.tsx — DisciplineCardDefinition needs manaType, card needs to render it
  • src/lib/game/constants/elements.ts — ELEMENTS has display info (sym, color, name)

Example

A discipline using fire mana should show something like:

🔥 Fire Mana
Drain: 2.0/tick

With the fire emoji and orange color (#FF6B35).

## UI Issue: Unclear what mana types are drained when practicing a discipline ### Description When a player looks at a discipline card, it's not obvious which mana type will be consumed while practicing. The `manaType` field exists in the data model but is never displayed in the UI. ### Current State - `DisciplineDefinition.manaType` exists and is used in `discipline-slice.ts` `processTick()` to determine which mana pool to drain - The `DisciplineCardDefinition` interface in `DisciplinesTab.tsx` does NOT include `manaType` - The `DisciplineCard` component never renders the mana type - Players must guess or external-reference which mana type a discipline uses ### Expected Behavior Each discipline card should prominently display: - The **primary mana type** consumed (e.g., "🔥 Fire", "💧 Water", "🔗 Transference") - Use the element's emoji/symbol and color from `ELEMENTS` constants - If a discipline uses raw mana, show "⚪ Raw Mana" - Consider also showing the **drain rate** in context of the mana type (e.g., "Drains 2.5 🔥/tick") ### Files Involved - `src/components/game/tabs/DisciplinesTab.tsx` — `DisciplineCardDefinition` needs `manaType`, card needs to render it - `src/lib/game/constants/elements.ts` — `ELEMENTS` has display info (sym, color, name) ### Example A discipline using fire mana should show something like: ``` 🔥 Fire Mana Drain: 2.0/tick ``` With the fire emoji and orange color (#FF6B35).
Anexim added the ai:todo label 2026-05-25 11:36:12 +02:00
n8n-gitea was assigned by Anexim 2026-05-25 11:36:12 +02:00
Anexim commented 2026-05-25 12:56:40 +02:00
Author
Owner
Copy Link
Copy Source

Investigation Result: Issue #132 appears to already be resolved in the current codebase.

The DisciplineCardDefinition interface already includes manaType: ManaType (line ~57), and the DisciplineCard component already renders a styled badge with the element's emoji, name, and color in the card header (lines ~113-125):

<span style={{ backgroundColor: `${manaColor}20`, borderColor: `${manaColor}60`, color: manaColor }}>
  <span>{manaIcon}</span>
  <span>{manaName}</span>
</span>

The mana type is displayed prominently next to the discipline name. Marking as done.

**Investigation Result:** Issue #132 appears to already be resolved in the current codebase. The `DisciplineCardDefinition` interface already includes `manaType: ManaType` (line ~57), and the `DisciplineCard` component already renders a styled badge with the element's emoji, name, and color in the card header (lines ~113-125): ```tsx <span style={{ backgroundColor: `${manaColor}20`, borderColor: `${manaColor}60`, color: manaColor }}> <span>{manaIcon}</span> <span>{manaName}</span> </span> ``` The mana type is displayed prominently next to the discipline name. Marking as done.
Anexim commented 2026-05-25 12:56:40 +02:00
Author
Owner
Copy Link
Copy Source

Mana type is already displayed on discipline cards as a colored badge with emoji and element name. The issue appears to have been resolved previously.

Mana type is already displayed on discipline cards as a colored badge with emoji and element name. The issue appears to have been resolved previously.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?