Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[priority: medium] EffectSelector shows "Learn Enchanting skill" instead of checking attunement level #188

New Issue
Closed
opened 2026-05-28 15:57:24 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-28 15:57:24 +02:00
Owner
Copy Link
Copy Source

Bug: EffectSelector shows outdated "Learn Enchanting skill" message

Description

In the Crafting tab > Enchanter subtab > Design phase, the EffectSelector component shows:

"Learn Enchanting skill to design enchantments"

This message is outdated — there is no longer an "Enchanting skill" in the game. The game now uses attunements (Enchanter attunement level).

Root Cause Analysis

In EffectSelector.tsx line 29-33:

{enchantingLevel < 1 ? (
  <div className="text-center text-[var(--text-muted)] py-8">
    <Wand2 className="w-12 h-12 mx-auto mb-2 opacity-50 text-[var(--text-disabled)]" />
    <p>Learn Enchanting skill to design enchantments</p>
  </div>

The enchantingLevel prop is passed from EnchantmentDesigner.tsx as a hardcoded 0:

<EffectSelector
  ...
  enchantingLevel={0}
  ...
/>

So the condition enchantingLevel < 0 is ALWAYS true, and the message is always shown — even though the player starts with Enchanter attunement level 1.

Affected Files

  • src/components/game/crafting/EnchantmentDesigner/EffectSelector.tsx — the conditional display
  • src/components/game/crafting/EnchantmentDesigner.tsx — passes enchantingLevel={0}

Steps to Reproduce

  1. Open Crafting tab
  2. Go to Enchanter subtab
  3. Click "Design" phase
  4. See the "Learn Enchanting skill" message instead of the effect selector

Expected Behavior

  • The effect selector should be visible when the player has Enchanter attunement level >= 1
  • The message should reference attunements, not skills
  • Since the player starts with Enchanter level 1, the effect selector should be immediately visible

Suggested Fix Direction

  1. Replace enchantingLevel with the actual Enchanter attunement level from useAttunementStore
  2. Update the message to say "Reach Enchanter attunement level 1 to design enchantments" if needed
  3. Or simply remove the gate entirely since Enchanter is the starting attunement
## Bug: EffectSelector shows outdated "Learn Enchanting skill" message ### Description In the Crafting tab > Enchanter subtab > Design phase, the EffectSelector component shows: > "Learn Enchanting skill to design enchantments" This message is outdated — there is no longer an "Enchanting skill" in the game. The game now uses attunements (Enchanter attunement level). ### Root Cause Analysis In `EffectSelector.tsx` line 29-33: ```tsx {enchantingLevel < 1 ? ( <div className="text-center text-[var(--text-muted)] py-8"> <Wand2 className="w-12 h-12 mx-auto mb-2 opacity-50 text-[var(--text-disabled)]" /> <p>Learn Enchanting skill to design enchantments</p> </div> ``` The `enchantingLevel` prop is passed from `EnchantmentDesigner.tsx` as a hardcoded `0`: ```tsx <EffectSelector ... enchantingLevel={0} ... /> ``` So the condition `enchantingLevel < 0` is ALWAYS true, and the message is always shown — even though the player starts with Enchanter attunement level 1. ### Affected Files - `src/components/game/crafting/EnchantmentDesigner/EffectSelector.tsx` — the conditional display - `src/components/game/crafting/EnchantmentDesigner.tsx` — passes `enchantingLevel={0}` ### Steps to Reproduce 1. Open Crafting tab 2. Go to Enchanter subtab 3. Click "Design" phase 4. See the "Learn Enchanting skill" message instead of the effect selector ### Expected Behavior - The effect selector should be visible when the player has Enchanter attunement level >= 1 - The message should reference attunements, not skills - Since the player starts with Enchanter level 1, the effect selector should be immediately visible ### Suggested Fix Direction 1. Replace `enchantingLevel` with the actual Enchanter attunement level from `useAttunementStore` 2. Update the message to say "Reach Enchanter attunement level 1 to design enchantments" if needed 3. Or simply remove the gate entirely since Enchanter is the starting attunement
Anexim added the ai:todo label 2026-05-28 15:57:24 +02:00
n8n-gitea was assigned by Anexim 2026-05-28 15:57:24 +02:00
Anexim commented 2026-05-28 19:54:25 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on issue #188. Root cause identified: EnchantmentDesigner.tsx passes enchantingLevel={0} (hardcoded), so the "Learn Enchanting skill" message always shows. Fix: read actual Enchanter attunement level from useAttunementStore.

Starting work on issue #188. Root cause identified: `EnchantmentDesigner.tsx` passes `enchantingLevel={0}` (hardcoded), so the "Learn Enchanting skill" message always shows. Fix: read actual Enchanter attunement level from `useAttunementStore`.
Anexim commented 2026-05-28 21:02:07 +02:00
Author
Owner
Copy Link
Copy Source

✅ Fixed. EnchantmentDesigner.tsx now reads the actual Enchanter attunement level from useAttunementStore instead of hardcoding enchantingLevel={0}. The EffectSelector now shows immediately since the player starts with Enchanter level 1.

✅ Fixed. `EnchantmentDesigner.tsx` now reads the actual Enchanter attunement level from `useAttunementStore` instead of hardcoding `enchantingLevel={0}`. The EffectSelector now shows immediately since the player starts with Enchanter level 1.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?